/TypeScript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring support #15569

Merged
merged 1 commit into from May 19, 2017
+776 −78

Conversation

Reviewers

@mhegazy mhegazy

@billti billti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RyanCavanaugh @mhegazy @msftclas
@RyanCavanaugh
Member

RyanCavanaugh commented May 3, 2017

Picks up where #14624 left off.

@msftclas msftclas added the cla-not-required label May 3, 2017

@RyanCavanaugh

This comment has been minimized.

Show comment
Hide comment
@RyanCavanaugh

RyanCavanaugh May 8, 2017

Member

Anyone want to take a look? The VS side is about to merge
Member

RyanCavanaugh commented May 8, 2017

Anyone want to take a look? The VS side is about to merge

@RyanCavanaugh RyanCavanaugh requested review from billti and mhegazy May 8, 2017

Show outdated Hide outdated src/compiler/types.ts
Show outdated Hide outdated src/server/protocol.ts
Show outdated Hide outdated src/server/protocol.ts
Show outdated Hide outdated src/services/codefixes/convertFunctionToEs6Class.ts
Show outdated Hide outdated src/services/codeFixProvider.ts
Show outdated Hide outdated src/services/codefixes/convertFunctionToEs6Class.ts
Show outdated Hide outdated src/services/codeFixProvider.ts
Show outdated Hide outdated src/services/refactorProvider.ts
Show outdated Hide outdated src/services/refactors/addAsyncSuffix.ts
Show outdated Hide outdated src/services/refactors/addAsyncSuffix.ts
Show outdated Hide outdated src/services/refactorProvider.ts
Show outdated Hide outdated src/services/refactors/addAsyncSuffix.ts
Show outdated Hide outdated src/services/refactors/addAsyncSuffix.ts
Show outdated Hide outdated src/services/refactors/addAsyncSuffix.ts
Show outdated Hide outdated src/services/refactors/addAsyncSuffix.ts
src/services/refactors/convertFunctionToEs6Class.ts
}
// all static members are stored in the "exports" array of symbol
if (symbol.exports) {

This comment has been minimized.

Show comment
Hide comment
@mhegazy

mhegazy May 15, 2017

Contributor

Is this intended for a .ts or a .js file?

I think it is a .js file, since the binding for the special properties do not work in .ts files any way.

If my understanding is correct, then for static members we can not just add declarations for them, this will result in invalid .js class.

this also applies to the property declarations and assignments..

If we want this to work in a .ts file, then we need to do something with the inference to make it work first.

I would also recommend adding a check at the top of isApplicable to return if !inJavaScriptFile(node)
Copy URL
@mhegazy

mhegazy May 15, 2017

Contributor

Is this intended for a .ts or a .js file?

I think it is a .js file, since the binding for the special properties do not work in .ts files any way.

If my understanding is correct, then for static members we can not just add declarations for them, this will result in invalid .js class.

this also applies to the property declarations and assignments..

If we want this to work in a .ts file, then we need to do something with the inference to make it work first.

I would also recommend adding a check at the top of isApplicable to return if !inJavaScriptFile(node)

This comment has been minimized.

Show comment
Hide comment
@mhegazy

mhegazy May 15, 2017

Contributor

also for member initialization, I wounder if we can even do these correctellly...

var c = function() { this.list.push(1); }
c.prototype.list = [];

is not the same as:

class c {
    constructor() { this.list.push(1); }
    list = [];

let a side that it is not valid JS strictly speaking.
Copy URL
@mhegazy

mhegazy May 15, 2017

Contributor

also for member initialization, I wounder if we can even do these correctellly...

var c = function() { this.list.push(1); }
c.prototype.list = [];

is not the same as:

class c {
    constructor() { this.list.push(1); }
    list = [];

let a side that it is not valid JS strictly speaking.

This comment has been minimized.

Show comment
Hide comment
@RyanCavanaugh

RyanCavanaugh May 17, 2017

Member

Fixed these up. Non-func-expr things remain as assignments following the class body
Copy URL
@RyanCavanaugh

RyanCavanaugh May 17, 2017

Member

Fixed these up. Non-func-expr things remain as assignments following the class body
Show outdated Hide outdated src/services/services.ts
Show outdated Hide outdated src/services/refactorProvider.ts
Show outdated Hide outdated src/services/refactorProvider.ts
Show outdated Hide outdated src/services/refactorProvider.ts

@angelozerr angelozerr referenced this pull request May 16, 2017

Closed

Refactoring Support #178

@mjbvz mjbvz referenced this pull request May 19, 2017

Closed

Support refactoring commands provided by TS Server #25739

@RyanCavanaugh
Refactoring support (squash)
Loading status checks…
f6fbe61

@RyanCavanaugh RyanCavanaugh merged commit f489f5a into Microsoft:master May 19, 2017
4 checks passed

4 checks passed

TypeScript Test Run typescript_node.4 Build finished.
Details
TypeScript Test Run typescript_node.6 Build finished.
Details
TypeScript Test Run typescript_node.stable Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RyanCavanaugh RyanCavanaugh deleted the RyanCavanaugh:new_refactor branch May 19, 2017

src/server/protocol.ts
export type GetApplicableRefactors = "getApplicableRefactors";
export type GetRefactorCodeActions = "getRefactorCodeActions";
export type GetRefactorCodeActionsFull = "getRefactorCodeActions-full";

This comment has been minimized.

Show comment
Hide comment
@mhegazy

mhegazy May 19, 2017

Contributor

This should be marked as /* @internal */
Copy URL
@mhegazy

mhegazy May 19, 2017 •
edited
Edited 1 time
  • @mhegazy mhegazy edited May 19, 2017 (most recent)

Contributor

This should be marked as /* @internal */
src/server/protocol.ts
export type RefactorCodeActions = {
actions: protocol.CodeAction[];
renameLocation?: number

This comment has been minimized.

Show comment
Hide comment
@mhegazy

mhegazy May 19, 2017

Contributor

A comment here would be good.
Copy URL
@mhegazy

mhegazy May 19, 2017

Contributor

A comment here would be good.
src/services/refactorProvider.ts
program: Program;
newLineCharacter: string;
rulesProvider?: formatting.RulesProvider;
cancellationToken?: CancellationToken;

This comment has been minimized.

Show comment
Hide comment
@mhegazy

mhegazy May 19, 2017

Contributor

why is this optional?
Copy URL
@mhegazy

mhegazy May 19, 2017

Contributor

why is this optional?
src/services/refactorProvider.ts
endPosition?: number;
program: Program;
newLineCharacter: string;
rulesProvider?: formatting.RulesProvider;

This comment has been minimized.

Show comment
Hide comment
@mhegazy

mhegazy May 19, 2017

Contributor

why is this optional?
Copy URL
@mhegazy

mhegazy May 19, 2017

Contributor

why is this optional?

@mhegazy mhegazy referenced this pull request May 19, 2017

Closed

Add infrastructure for refactors #14624

@renovate-bot renovate-bot referenced this pull request May 22, 2017

Merged

Update dependency typescript to version 2.3.3 #297

@mhegazy mhegazy referenced this pull request May 22, 2017

Closed

Pvb/refactorapi #11913

mjbvz added a commit to mjbvz/vscode that referenced this pull request May 23, 2017

@mjbvz
Prototype TS/JS Refactoring Provider 
Fixes #25739, from Microsoft/TypeScript#15569

Prototype of refactoring support for ts 2.4
57a5629

@mjbvz mjbvz referenced this pull request May 23, 2017

Merged

Prototype TS/JS Refactoring Provider #27166

@mhegazy mhegazy referenced this pull request May 24, 2017

Closed

Pvb/refactor/jsdoc #11951

@bryphe bryphe referenced this pull request Jun 4, 2017

Open

Refactoring Support #474

mjbvz added a commit to mjbvz/vscode that referenced this pull request Jun 12, 2017

@mjbvz
Prototype TS/JS Refactoring Provider 
Fixes #25739, from Microsoft/TypeScript#15569

Prototype of refactoring support for ts 2.4
d1b2c60

mjbvz added a commit to mjbvz/vscode that referenced this pull request Jun 14, 2017

@mjbvz
Prototype TS/JS Refactoring Provider 
Fixes #25739, from Microsoft/TypeScript#15569

Prototype of refactoring support for ts 2.4
136994f

mjbvz added a commit to mjbvz/vscode that referenced this pull request Jun 16, 2017

@mjbvz
Prototype TS/JS Refactoring Provider 
Fixes #25739, from Microsoft/TypeScript#15569

Prototype of refactoring support for ts 2.4
dfadffe

mjbvz added a commit to Microsoft/vscode that referenced this pull request Jun 16, 2017

@mjbvz
Prototype TS/JS Refactoring Provider (#27166) 
* Prototype TS/JS Refactoring Provider

Fixes #25739, from Microsoft/TypeScript#15569

Prototype of refactoring support for ts 2.4

* Adding error reporting

* Updating for new API

* show quick pick for non-inlinable refactrings
Loading status checks…
1564137

ananthakumaran added a commit to ananthakumaran/tide that referenced this pull request Jul 8, 2017

@ananthakumaran
add support for refactor command 
introduced by Microsoft/TypeScript#15569
Loading status checks…
6534f73

@ananthakumaran ananthakumaran referenced this pull request Jul 8, 2017

Merged

add support for refactor command #172

ananthakumaran added a commit to ananthakumaran/tide that referenced this pull request Jul 30, 2017

@ananthakumaran
add support for refactor command 
introduced by Microsoft/TypeScript#15569
Loading status checks…
f921a42

@Microsoft Microsoft locked and limited conversation to collaborators Jun 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.