Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence NPM warnings when installing typings #19749

Merged
merged 1 commit into from Nov 6, 2017

Conversation

@micbou
Copy link
Contributor

@micbou micbou commented Nov 5, 2017

Even with PR #19663, NPM still outputs warnings about mandatory fields in package.json when installing typings because these fields must be set to something else than an empty string.

Fixes #19660.


This change is Reviewable

@andy-ms
Copy link
Contributor

@andy-ms andy-ms commented Nov 5, 2017

Will { "private": true } work?

@micbou micbou force-pushed the micbou:fix-package-json-fields branch from df2d5c9 to dde4f61 Nov 5, 2017
@micbou micbou changed the title Properly set package.json fields in typings installer Silence NPM warnings when installing typings Nov 5, 2017
@micbou
Copy link
Contributor Author

@micbou micbou commented Nov 5, 2017

Yes, it works. PR updated.

@andy-ms
andy-ms approved these changes Nov 6, 2017
@mhegazy mhegazy merged commit d97335e into microsoft:master Nov 6, 2017
5 checks passed
5 checks passed
TypeScript Test Run typescript_node.6 Build finished.
Details
TypeScript Test Run typescript_node.8 Build finished.
Details
TypeScript Test Run typescript_node.stable Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.