New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDeclarationName: support ComputedPropertyName #22123

Merged
merged 2 commits into from Feb 22, 2018

Conversation

Projects
None yet
3 participants
@andy-ms
Contributor

andy-ms commented Feb 22, 2018

As of #15473 we should be getting symbols on computed property names, so we might as well include those in our baselines.
Also note the symbolProperty24.errors.txt change, which required changing a symbol.escapedName use to symbolToString (#21009).

@andy-ms andy-ms requested review from rbuckton, weswigham and sandersn Feb 22, 2018

@andy-ms andy-ms merged commit a299d2d into master Feb 22, 2018

5 checks passed

TypeScript Test Run typescript_node.6 Build finished.
Details
TypeScript Test Run typescript_node.8 Build finished.
Details
TypeScript Test Run typescript_node.stable Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@andy-ms andy-ms deleted the computed_property_is_declaration_name branch Feb 22, 2018

@Microsoft Microsoft locked and limited conversation to collaborators Jul 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.