Cache module resolutions across tsbuild to be able to resolve the modules faster #31100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
approved these changes
Apr 25, 2019
|
Does this benefit |
|
@DanielRosenwasser little bit but not much (if their project contained references and references had same options as the project being compiled, it will) |
ajafff
reviewed
May 3, 2019
| optionsHaveModuleResolutionChanges(oldOptions, newOptions); | ||
| } | ||
|
|
||
| export function optionsHaveModuleResolutionChanges(oldOptions: CompilerOptions, newOptions: CompilerOptions) { |
There was a problem hiding this comment.
@sheetalkamat would it be reasonable to expose this function in the public API? That would allow API users to reuse their ModuleResolutionCache until changes in CompilerOptions require a new cache.
There was a problem hiding this comment.
Sure. Note that this only compares CompilerOptions and not changes in directory structure which could affect the module resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first of many optimizations done for building 800+ reference projects
cc @MLoughry as its coming from the repro he provided
Note this caching is currently only for building first time, In the watch mode, we need to reset the cache correctly which isn't done yet for anything really, Given that set is minimal it should be ok for now but that would be handled as part of api creation.