Allow duplicate identifiers across declarations. #8696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if (hasProperty(names, memberName)) { | ||
| error(member, Diagnostics.Duplicate_identifier_0, memberName); |
There was a problem hiding this comment.
member.name for the error range.
There was a problem hiding this comment.
We report the duplicate declaration errors on all declarations, as ppl complained they could not find the other one when we reported only on one declaration.
There was a problem hiding this comment.
I wonder if we need to keep doing that since now it's guaranteed to be in the same block
There was a problem hiding this comment.
i see. yeah you are probably right.
|
do not see the handling for optionality. |
|
|
||
| if (hasProperty(names, memberName)) { | ||
| error(member.symbol.valueDeclaration, Diagnostics.Duplicate_identifier_0, memberName); | ||
| error(member, Diagnostics.Duplicate_identifier_0, memberName); |
There was a problem hiding this comment.
member.name to get a better error span.
|
also can you add a test for computed properties class C {
["a"]: 1,
["a"]: 2
} |
|
Last call |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8675
Duplicate identifiers within the same block are still disallowed. Additionally, we retain the restriction that the types of the declared symbols must be identical.