Added Latitude and Longitude to a returning Tweet if available. #735

Merged
merged 4 commits into from Jan 5, 2017

Projects

None yet

4 participants

@SpilledMilkCOM
Contributor

The TwitterGeoData is deserialized if the "geo" element is populated on the response JSON. I added the DisplayCoordinates to the TwitterGeoData since I didn't see a TwitterModel for the UI. After I put in the double conversion I felt that it wasn't really needed, but I was just following the pattern for the CreationDate. The TwitterGeoData could just expose the string data.

@dnfclas
dnfclas commented Dec 19, 2016

Hi @SpilledMilkCOM, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@deltakosh
Contributor

Excellent! Thanks a lot

@deltakosh
Contributor

Do you mind updating the documentation as well?

@SpilledMilkCOM
Contributor

I don't see the Tweet class described in the documentation. I just assumed that people would dig into the code and look at the documentation inside of Tweet.cs, which is why I only documented the TwitterGeoData class. Maybe I'm looking at the wrong doc file. (docs/services/Twitter.md)

@deltakosh
Contributor

This is true because tweets where just text but now they become more powerful :)

@SpilledMilkCOM
Contributor

I hope this is enough. I wanted to keep things simple. I tried to put the properties in a markdown table, but I wasn't sure what "flavor" of markdown people use. The standard table markdown didn't really look like a table using one of the MarkDown Preview Plus in Chrome. I just used a list (bullets).

@deltakosh deltakosh merged commit 01f6f2f into Microsoft:dev Jan 5, 2017
@deltakosh
Contributor

Really great thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment