Typo fix (for Issue #783) #784

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@mrlacey
Contributor
mrlacey commented Jan 11, 2017

for #783

mrlacey added some commits Jan 11, 2017
@mrlacey mrlacey Test illegal path characters are detected (issue 781)
Added illegal path characters to the failing test for illegal characters
dc53e29
@mrlacey mrlacey Typo fix for #783 d112e8d
@dnfclas
dnfclas commented Jan 11, 2017

Hi @mrlacey, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@@ -239,7 +239,7 @@ public void Test_StorageFileHelper_IsFilePathValid_WithCorrectFilePath()
[TestMethod]
public void Test_StorageFileHelper_IsFilePathValid_WithIllegalCharacters()
{
- string filepath = "my_folder/my_file.txt";
+ string filepath = "my>folder|my<file\t.txt";
@ScottIsAFool
ScottIsAFool Jan 11, 2017 Collaborator

Was this meant to be included in this PR?

@mrlacey
mrlacey Jan 11, 2017 Contributor

oops, I've got two PRs combined somehow. help?

@ScottIsAFool
ScottIsAFool Jan 11, 2017 Collaborator

Honestly, given the size of the PR, I'd say you'd be better off and quicker just redoing it on a new branch and close this PR.

@mrlacey
mrlacey Jan 11, 2017 Contributor

recreated at #785

@mrlacey
Contributor
mrlacey commented Jan 11, 2017

closing and recreating without the incorrectly included file

@mrlacey mrlacey closed this Jan 11, 2017
@mrlacey mrlacey deleted the mrlacey:issue783 branch Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment