New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji support to Windows Console #590

Closed
bitcrazed opened this Issue Jun 27, 2016 · 16 comments

Comments

Projects
None yet
10 participants
@bitcrazed
Copy link
Collaborator

bitcrazed commented Jun 27, 2016

Windows Console does not support emoji and other extended character-sets, as reported by the emoj team: sindresorhus/emoj#5 (comment)

Consider adding emoji support to Windows Console in the future

@bitcrazed bitcrazed self-assigned this Jun 27, 2016

@MadcowD

This comment has been minimized.

Copy link

MadcowD commented Jun 29, 2016

Come on; at least give us GPU support first.

@be5invis

This comment has been minimized.

Copy link
Member

be5invis commented Aug 3, 2016

@bitcrazed
Are you going to rewrite the entire CONHOST and console C/C++ API?
Gee...

@bitcrazed

This comment has been minimized.

Copy link
Collaborator

bitcrazed commented Mar 9, 2017

@be5invis Rewrite? Only the parts that desperately need it. Otherwise, we're re-architecting and modularizing much of the Console internals which will result in us being able to iterate FAR faster, and more confidently & safely.

@SandHilt

This comment has been minimized.

Copy link

SandHilt commented Mar 16, 2017

Make console great again.

@jackchammons jackchammons removed the bug label Apr 11, 2017

@fcharlie

This comment has been minimized.

Copy link

fcharlie commented Jun 7, 2017

Is there any progress in supporting emoji ?

@be5invis

This comment has been minimized.

Copy link
Member

be5invis commented Jun 7, 2017

@fcharlie This is very hard, the entire console buffer is a fixed data structure that each cell has only 16 bits.

@be5invis

This comment has been minimized.

Copy link
Member

be5invis commented Jun 7, 2017

@fcharlie And it has C++ interfaces...
Means that we cannot change that.

@fcharlie

This comment has been minimized.

Copy link

fcharlie commented Jun 9, 2017

@be5invis I use WriteConsoleW output emoji ❤️ ,mybe use DirectWrite can output more Emoji

wsudo

@coreh

This comment has been minimized.

Copy link

coreh commented Nov 4, 2017

Not entirely sure on the internals, but it should be possible to affect only the rendering, without changing the underlying memory structure. (Even if the character spacing becomes "off" with emoji taking up the space of two regular characters, that would be a fine compromise)

@bitcrazed

This comment has been minimized.

Copy link
Collaborator

bitcrazed commented Nov 6, 2017

'it should be possible to affect only the rendering, without changing the underlying memory structure'

Sure ... if you're starting from scratch, you might chose some flexible encoding like UTF-8 (though that has it's own perf costs to consider), but doesn't help you when the Console's internal buffers are currently UCS-2 based and can't fully deal with Unicode scenarios including zero-width joiners, and surrogate pairs.

And in amongst the work to handle Unicode encodings that we don't currently support (e.g. UTF-8), we have to modularize and wrap the internal buffers, expose an API that the rest of the Console is modified to call, rather than allowing external code to delve into the data structures and directly manipulate memory in a somewhat haphazard manner!

@HotelCalifornia

This comment has been minimized.

Copy link

HotelCalifornia commented Apr 19, 2018

I hate to be that guy, but have there been any updates to this?

@bitcrazed

This comment has been minimized.

Copy link
Collaborator

bitcrazed commented Apr 20, 2018

@HotelCalifornia - You are now, officially, THAT guy ;) :D

While we've not moved forward on this feature of late, we HAVE completed a ton of stuff & this ask is edging up the backlog.

A few more things to get to yet, but it's getting closer.

Bear with us!

@stereokai

This comment has been minimized.

Copy link

stereokai commented Apr 21, 2018

@bitcrazed thanks for the honest update. Does that mean UTF-8 is also on the way?

@bitcrazed

This comment has been minimized.

Copy link
Collaborator

bitcrazed commented Apr 24, 2018

Absolutely. UTF-8 support is a pre-req' for us to eventually support emoji, and many other complex languages, symbols, etc.

@bitcrazed

This comment has been minimized.

Copy link
Collaborator

bitcrazed commented May 22, 2018

Thanks for the discussion.

Closing this issue since:

  1. As noted above, we've a long list of work items that'll enable Console to store and render MUCH more of the UNICODE glyph space. It'll take us a while to get through them, but the work has begun
  2. This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
  3. GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.

@bitcrazed bitcrazed closed this May 22, 2018

@HLFH

This comment has been minimized.

Copy link

HLFH commented May 23, 2018

Ok @bitcrazed

Go here: Microsoft/console#190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment