Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated publish_actions and dependencies #2307

Merged
merged 3 commits into from Jul 23, 2018
Merged

Conversation

cbarkerms
Copy link
Contributor

Issue: #2273

PR Type

What kind of change does this PR introduce?

Other... Please describe: Feature deprecation

What is the current behavior?

See 2273
Facebook deprecated the publish_actions permission - the toolkit Facebook service and Facebook app fail to login/post actions.

What is the new behavior?

Deprecated the methods that depend on publish_actions, removed features from the sample app that leveraged the publish_actions feature.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

The FacebookService methods affected have been marked deprecated - they should fail silently if called. Apps consuming the service will need to explicitly stop initializing with the PublishActions permission otherwise login will eventually fail. Posts will now need to be leveraged via the supported PostToFeedWithDialogAsync method - this will likely not satisfy all existing scenarios and so future work may be required to increase the features supported by this method.

Other information

@azchohfi azchohfi merged commit 8b73e33 into master Jul 23, 2018
@azchohfi azchohfi deleted the cbarker/issue2273 branch July 23, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants