New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Project Rome Web to app link #180

Closed
crutkas opened this Issue Apr 11, 2017 · 11 comments

Comments

Projects
None yet
5 participants
@crutkas

This comment has been minimized.

Show comment
Hide comment
@crutkas

crutkas Jun 23, 2017

Member

this should basically be a link to the docs and allowing for an HTTP entry point to the app

Member

crutkas commented Jun 23, 2017

this should basically be a link to the docs and allowing for an HTTP entry point to the app

@mrlacey

This comment has been minimized.

Show comment
Hide comment
@mrlacey

mrlacey Jun 23, 2017

Collaborator

this should basically be a link to the docs and allowing for an HTTP entry point to the app

Are you saying we have a feature that just adds comments to the generated code that link to the docs?
Doesn't seem like it'd be very helpful.

Collaborator

mrlacey commented Jun 23, 2017

this should basically be a link to the docs and allowing for an HTTP entry point to the app

Are you saying we have a feature that just adds comments to the generated code that link to the docs?
Doesn't seem like it'd be very helpful.

@crutkas

This comment has been minimized.

Show comment
Hide comment
@crutkas

crutkas Jun 26, 2017

Member

would be

  • added in the app handler with a Todo to update.
  • add in a todo in the app.xaml.cs for them to add in json file
  • add in code block for the scheme launch so you can do:
    if (e.Kind == ActivationKind.Protocol)
    {
        var protocolArgs = (ProtocolActivatedEventArgs)e;        
        switch (protocolArgs.Uri.AbsolutePath)
        {
            case "/":
                break;
            case "/index.html":
                break;
            case "/sports.html":
                deepLinkPageType = typeof(SportsPage);
                break;
            case "/technology.html":
                deepLinkPageType = typeof(TechnologyPage);
                break;
            case "/business.html":
                deepLinkPageType = typeof(BusinessPage);
                break;
            case "/science.html":
                deepLinkPageType = typeof(SciencePage);
                break;
        }
    }```
Member

crutkas commented Jun 26, 2017

would be

  • added in the app handler with a Todo to update.
  • add in a todo in the app.xaml.cs for them to add in json file
  • add in code block for the scheme launch so you can do:
    if (e.Kind == ActivationKind.Protocol)
    {
        var protocolArgs = (ProtocolActivatedEventArgs)e;        
        switch (protocolArgs.Uri.AbsolutePath)
        {
            case "/":
                break;
            case "/index.html":
                break;
            case "/sports.html":
                deepLinkPageType = typeof(SportsPage);
                break;
            case "/technology.html":
                deepLinkPageType = typeof(TechnologyPage);
                break;
            case "/business.html":
                deepLinkPageType = typeof(BusinessPage);
                break;
            case "/science.html":
                deepLinkPageType = typeof(SciencePage);
                break;
        }
    }```

@crutkas crutkas modified the milestones: 1.3, 1.2 Jul 5, 2017

@crutkas crutkas modified the milestones: 1.4, 1.3 Aug 30, 2017

@crutkas crutkas modified the milestones: 1.4, 1.5 Sep 19, 2017

@ralarcon ralarcon modified the milestones: 1.5, Backlog Oct 27, 2017

@ralarcon

This comment has been minimized.

Show comment
Hide comment
@ralarcon

ralarcon Oct 27, 2017

Contributor

@crutkas @mrlacey we now this will not be able to be released in 1.5, moving to backlog to be planned in future releases.

Contributor

ralarcon commented Oct 27, 2017

@crutkas @mrlacey we now this will not be able to be released in 1.5, moving to backlog to be planned in future releases.

@crutkas

This comment has been minimized.

Show comment
Hide comment
@crutkas

crutkas Oct 27, 2017

Member

I feel like this is really easy to execute and pull off. We really should look at this as a easy feature to implement.

Member

crutkas commented Oct 27, 2017

I feel like this is really easy to execute and pull off. We really should look at this as a easy feature to implement.

@ralarcon

This comment has been minimized.

Show comment
Hide comment
@ralarcon

ralarcon Oct 30, 2017

Contributor

If finally we remove the multi-view we will include it. Agree?

Contributor

ralarcon commented Oct 30, 2017

If finally we remove the multi-view we will include it. Agree?

@crutkas

This comment has been minimized.

Show comment
Hide comment
@crutkas

crutkas Oct 30, 2017

Member

Sure. With URI launch code, this should be pretty straight forward.

Member

crutkas commented Oct 30, 2017

Sure. With URI launch code, this should be pretty straight forward.

@mvegaca mvegaca self-assigned this Oct 31, 2017

@mvegaca mvegaca modified the milestones: Backlog, 1.5 Oct 31, 2017

@mvegaca mvegaca added the in-progress label Oct 31, 2017

@mvegaca

This comment has been minimized.

Show comment
Hide comment
@mvegaca

mvegaca Oct 31, 2017

Member

Working on a PoC on this branch

The PoC contains a Package.appxmanifest and an Activation Handler that allows opening the app when the app is launched from a Uri.

You can have a look here and comment what you think.

Member

mvegaca commented Oct 31, 2017

Working on a PoC on this branch

The PoC contains a Package.appxmanifest and an Activation Handler that allows opening the app when the app is launched from a Uri.

You can have a look here and comment what you think.

@mvegaca

This comment has been minimized.

Show comment
Hide comment
@mvegaca

mvegaca Nov 2, 2017

Member

Feature added on #1383

Member

mvegaca commented Nov 2, 2017

Feature added on #1383

@mvegaca

This comment has been minimized.

Show comment
Hide comment
@mvegaca

mvegaca Nov 23, 2017

Member

Ready to close, checked out on.
Wizard: 0.14.17327.65001
Templates: 0.14.17327.1

Member

mvegaca commented Nov 23, 2017

Ready to close, checked out on.
Wizard: 0.14.17327.65001
Templates: 0.14.17327.1

@mvegaca mvegaca closed this Nov 23, 2017

@ralarcon

This comment has been minimized.

Show comment
Hide comment
@ralarcon

ralarcon Nov 23, 2017

Contributor

We are waiting for feedback from Product Group team.

Contributor

ralarcon commented Nov 23, 2017

We are waiting for feedback from Product Group team.

@sibille sibille closed this Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment