New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add unit test project to solution #299

Open
mrlacey opened this Issue May 11, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@mrlacey
Collaborator

mrlacey commented May 11, 2017

Add a feature to add a unit test project to the solution. This should include a reference to the app project.

Need to consider what, if any, test(s) to include by default.

@mrlacey mrlacey added the feature label May 11, 2017

@jamesmcroft

This comment has been minimized.

Show comment
Hide comment
@jamesmcroft

jamesmcroft May 13, 2017

Collaborator

Similar to my comments in #300 - would this be optional as it currently is when creating a new blank project?

Collaborator

jamesmcroft commented May 13, 2017

Similar to my comments in #300 - would this be optional as it currently is when creating a new blank project?

@crutkas crutkas added this to the Backlog milestone May 13, 2017

@crutkas

This comment has been minimized.

Show comment
Hide comment
@crutkas

crutkas May 14, 2017

Member

why not just allow someone to opt in as a system level and make the whole project straight up testable. With that said, I can see how to do UI testing, but to do stub out a proper unit test without any business logic? feels odd as not sure how much would be testable

Member

crutkas commented May 14, 2017

why not just allow someone to opt in as a system level and make the whole project straight up testable. With that said, I can see how to do UI testing, but to do stub out a proper unit test without any business logic? feels odd as not sure how much would be testable

@mrlacey

This comment has been minimized.

Show comment
Hide comment
@mrlacey

mrlacey May 16, 2017

Collaborator

My thinking was that by making this a "feature" it becomes optional.
Yes, there's not a lot we can test but by making it easy to add unit testing to the solution we can hopefully help with its adoption.

Even if we only added a single test which included Assert.Inconclusive("TODO: Write some tests"); I would consider this better than doing nothing.

Collaborator

mrlacey commented May 16, 2017

My thinking was that by making this a "feature" it becomes optional.
Yes, there's not a lot we can test but by making it easy to add unit testing to the solution we can hopefully help with its adoption.

Even if we only added a single test which included Assert.Inconclusive("TODO: Write some tests"); I would consider this better than doing nothing.

@magol

This comment has been minimized.

Show comment
Hide comment
@magol

magol May 17, 2017

Perhaps add some commented examples of some types of tests that you can perform just to show how to best write tests based on selected conditions.

The conditions for writing tests differ depending on the chosen framework (Code behind, MVVM Basic, MVVM light, PRISM), how Dependency injection is performed, chosen unit test and mock framework, etc.

magol commented May 17, 2017

Perhaps add some commented examples of some types of tests that you can perform just to show how to best write tests based on selected conditions.

The conditions for writing tests differ depending on the chosen framework (Code behind, MVVM Basic, MVVM light, PRISM), how Dependency injection is performed, chosen unit test and mock framework, etc.

@mrlacey

This comment has been minimized.

Show comment
Hide comment
@mrlacey

mrlacey Mar 30, 2018

Collaborator

Once we get to FCU as a minimum SDK and split out potentially X-Plat functionality this could be 3 options:

  • Add a UWP unit test project that references the main app for testing the functionality it contains
  • A NetCore 2.0 project using MSTest that references the X-Plat library for testing X-Plat functionality
  • A NetCore 2.0 project using XUnit that references the X-Plat library for testing X-Plat functionality
Collaborator

mrlacey commented Mar 30, 2018

Once we get to FCU as a minimum SDK and split out potentially X-Plat functionality this could be 3 options:

  • Add a UWP unit test project that references the main app for testing the functionality it contains
  • A NetCore 2.0 project using MSTest that references the X-Plat library for testing X-Plat functionality
  • A NetCore 2.0 project using XUnit that references the X-Plat library for testing X-Plat functionality

@mrlacey mrlacey modified the milestones: Backlog, 2.1 Mar 30, 2018

@mrlacey

This comment has been minimized.

Show comment
Hide comment
@mrlacey

mrlacey Apr 11, 2018

Collaborator

moving back to backlog as timeline for major restructuring is now undetermined

Collaborator

mrlacey commented Apr 11, 2018

moving back to backlog as timeline for major restructuring is now undetermined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment