New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to batch builds on a per branch basis #1830

Closed
dalemyers opened this Issue Sep 14, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@dalemyers
Member

dalemyers commented Sep 14, 2018

What's not working?

Before we moved to YAML, we had half a dozen build definitions so that we could set different variables. Moving to YAML allowed us to consolidate these, with the exception of one variable: We cannot batch changes on a per branch basis any longer.

Our definition builds all branches (and is a policy for PRs). We'd like 3 of our branches to have their changes batched (on a per branch basis), but all the rest continue as is.

Currently, I cannot see any way to do that. Issue #1549 brings the first part, but without this remaining part, we are likely going to have to move back to multiple definitions anyway.

@TingluoHuang

This comment has been minimized.

Show comment
Hide comment
@TingluoHuang
Member

TingluoHuang commented Sep 14, 2018

@ericsciple

This comment has been minimized.

Show comment
Hide comment
@ericsciple
Member

ericsciple commented Sep 24, 2018

@ericsciple ericsciple closed this Sep 24, 2018

@dalemyers

This comment has been minimized.

Show comment
Hide comment
@dalemyers

dalemyers Sep 24, 2018

Member

That sets it on a per definition basis, not a per branch basis.

Member

dalemyers commented Sep 24, 2018

That sets it on a per definition basis, not a per branch basis.

@ericsciple

This comment has been minimized.

Show comment
Hide comment
@ericsciple

ericsciple Sep 24, 2018

Member

Batching is applied per branch. If not, that's a bug. Did you experience that behavior? If so, I'll see if I can reproduce the behavior you are describing.

Member

ericsciple commented Sep 24, 2018

Batching is applied per branch. If not, that's a bug. Did you experience that behavior? If so, I'll see if I can reproduce the behavior you are describing.

@ericsciple ericsciple reopened this Sep 24, 2018

@dalemyers

This comment has been minimized.

Show comment
Hide comment
@dalemyers

dalemyers Sep 24, 2018

Member

Yup. All our builds stopped bar one. I undid the change immediately without investigation though since obviously I don't want to kill our builds.

Member

dalemyers commented Sep 24, 2018

Yup. All our builds stopped bar one. I undid the change immediately without investigation though since obviously I don't want to kill our builds.

@ericsciple

This comment has been minimized.

Show comment
Hide comment
@ericsciple

ericsciple Sep 24, 2018

Member

I am not able to reproduce this behavior.

Here is the definition I used to test this on my personal account:

trigger:
  batch: true
  branches:
    include:
    - "*"
pool: hosted ubuntu 1604
steps:
- script: ping -c 600 127.0.0.1
Member

ericsciple commented Sep 24, 2018

I am not able to reproduce this behavior.

Here is the definition I used to test this on my personal account:

trigger:
  batch: true
  branches:
    include:
    - "*"
pool: hosted ubuntu 1604
steps:
- script: ping -c 600 127.0.0.1
@ericsciple

This comment has been minimized.

Show comment
Hide comment
@ericsciple

ericsciple Sep 24, 2018

Member

I wonder if what you experienced was a delay due to some other reason or if the UI was not up to date. I'm going to close this issue here for now since this feature appears to work correctly (or at least now it does). Please reopen if you are still having issues.

Member

ericsciple commented Sep 24, 2018

I wonder if what you experienced was a delay due to some other reason or if the UI was not up to date. I'm going to close this issue here for now since this feature appears to work correctly (or at least now it does). Please reopen if you are still having issues.

@ericsciple ericsciple closed this Sep 24, 2018

@dalemyers

This comment has been minimized.

Show comment
Hide comment
@dalemyers

dalemyers Sep 26, 2018

Member

I tried this again today to see if it would work. Here's what I did:

  1. I added a commit to the develop branch which contains the following added to the root level of the YAML file:
trigger:
  batch: true
  1. I then pushed this commit to the repo on VSTS. The commit did not build. It was never scheduled for building. I checked all our agents and none of them were showing as having an active build. There were no status updates on the commit as we'd expect if it was starting to build.

  2. I created a new branch based on this commit, made a change, commited and pushed. This branch also did not build. Adding another commit to this branch resulted in no build either.

I did not test what happened if I pushed a commit based on an earlier revision of develop as I needed to get the change back out. I also did not wait for existing builds to finish to see if one of the commits I pushed would get a build scheduled as I know from our previous test that this is in fact what happens.

It seems that this just isn't working for us and I have no idea why.

Member

dalemyers commented Sep 26, 2018

I tried this again today to see if it would work. Here's what I did:

  1. I added a commit to the develop branch which contains the following added to the root level of the YAML file:
trigger:
  batch: true
  1. I then pushed this commit to the repo on VSTS. The commit did not build. It was never scheduled for building. I checked all our agents and none of them were showing as having an active build. There were no status updates on the commit as we'd expect if it was starting to build.

  2. I created a new branch based on this commit, made a change, commited and pushed. This branch also did not build. Adding another commit to this branch resulted in no build either.

I did not test what happened if I pushed a commit based on an earlier revision of develop as I needed to get the change back out. I also did not wait for existing builds to finish to see if one of the commits I pushed would get a build scheduled as I know from our previous test that this is in fact what happens.

It seems that this just isn't working for us and I have no idea why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment