New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonarQube Scanner #77

Closed
viperx77 opened this Issue Feb 20, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@viperx77

viperx77 commented Feb 20, 2018

I would like the SonarQube.Scanner.MSBuild.exe (and dependencies) as default part of the VS 2017 Hosted Build Agent

@viperx77 viperx77 changed the title from Install SonarQube Scanner to Add SonarQube Scanner Feb 20, 2018

@chrisrpatterson

This comment has been minimized.

Member

chrisrpatterson commented Feb 20, 2018

I think those can easily be pulled at runtime as part of your build.

@viperx77

This comment has been minimized.

viperx77 commented Feb 21, 2018

Sure, anything could be pulled at runtime. What's the criteria for what should be added to the agent?

@bryanmacfarlane

This comment has been minimized.

Member

bryanmacfarlane commented Feb 21, 2018

Some stuff is much harder at runtime. Very large, msi's, requires reboots etc... It's a question of size, how easy to pull and how common is it. We have a finite amount of space on the image. Sonar is pretty common. If it's common and small then we should consider. But the other question is maintenance - we need to add tests, validation and support on every image generation. Which is of course possible but goes back to how common.

If it's trivial to pull, you can create an extension as a tool installer task (we have a category for that). Actually, it would be best if the SonarQube extension added that task. But that's an extra step for the consumer.

Judgement call for @chrisrpatterson

@chrisrpatterson

This comment has been minimized.

Member

chrisrpatterson commented Mar 16, 2018

The documentation seems to indicate that the extension already takes care of acquiring the scanner for msbuild https://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Extension+for+VSTS-TFS

@lokesh755 lokesh755 closed this Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment