New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service Deploy task fails due to incorrect isMSDeployPackage implementation #6946

Closed
BasLijten opened this Issue Apr 11, 2018 · 3 comments

Comments

Projects
None yet
6 participants
@BasLijten

BasLijten commented Apr 11, 2018

The vsts task "Azure App Service deploy" fails when a correct web deploy package has been provided. The error "Error: Source (Manifest) and destination (ContentPath) are not compatible for the given operation" will show up due to the following (generated) msdeploy command:
msdeploy -verb:sync -source:package=package.zip -dest:ContentPath=”azure-site...”

The function below checks whether or not the provided web deployment package is valid:
https://github.com/Microsoft/vsts-tasks/blob/81285d649ed7ed744ef107af55175b9e128a0c04/Tasks/Common/webdeployment-common/utility.ts#L151

It fails when there is no parameters.xml or systeminfo.xml. Due to its implementation, this check is case sensitive: when there is a SystemInfo.xml instead of systeminfo.xml, the function returns false and the command as shown above will bug out.

The proposed solution is to at least include "SystemInfo.xml", but preferably make this check case-insensitive.

a temporary workaround is to create a new msdeploy package. In my case, this leads to extra work, as this package has been provided by a 3rd party.

@KrishnaAdityaB

This comment has been minimized.

Contributor

KrishnaAdityaB commented Apr 19, 2018

@arjgupta you added this logic with this PR https://github.com/Microsoft/vsts-tasks/pull/3549/files#diff-a2b5b3ac78f6bfd42fd129f5a0d20787

Any reason why you went with only 2 case-sensitive cases?
Can I make this case insensitive?

@KrishnaAdityaB

This comment has been minimized.

Contributor

KrishnaAdityaB commented Apr 29, 2018

I will raise a PR with case insensitive check next week.

@vincentdass

This comment has been minimized.

Member

vincentdass commented May 9, 2018

The issue is resolved and the fix will be available in upcoming deployment.

@vincentdass vincentdass closed this May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment