New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1018491: Maven, fix for cc failure; fix for blank settings.xml with … #4744

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
4 participants
@lkillgore
Member

lkillgore commented Jul 7, 2017

…authenticated feeds

@@ -81,11 +81,6 @@ export class JacocoMavenCodeCoverageEnabler extends cc.JacocoCodeCoverageEnabler
protected addCodeCoverageNodes(buildJsonContent: any): Q.Promise<any> {
let _this = this;
if (!buildJsonContent.project.build) {

This comment has been minimized.

@lkillgore

lkillgore Jul 7, 2017

Member

This block prevented the 'default' code from working in getBuildDataNode(), which caused the bug

@lkillgore

lkillgore Jul 7, 2017

Member

This block prevented the 'default' code from working in getBuildDataNode(), which caused the bug

@jpricketMSFT

The changes look good to me.

@lkillgore lkillgore merged commit e086b4b into master Jul 7, 2017

@lkillgore lkillgore deleted the users/lukillgo/mavenccbugfix branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment