Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore existing packages in NugetTaskV2 on Linux #9666

Merged

Conversation

Projects
None yet
4 participants
@ptrstpp950
Copy link
Contributor

commented Feb 22, 2019

In the issue #3606 there was a request for allow skipping existing NuGet packages. The implementation was working on Windows agents, but on Linux not.
This pull request changes behaviour on Linux agents to support such functionality.

@msftclas

This comment has been minimized.

Copy link

commented Feb 22, 2019

CLA assistant check
All CLA requirements met.

@jotaylo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

This is a good compromise, but I'm concerned that the string comparison doesn't account for localization.
I'll mull over some options and get back to you.

@ptrstpp950

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@jotaylo I have a second idea: compile VstsNuGet in dotnet core or make it compatible with linux. But I cannot find source code of it.

@jotaylo

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

VstsNugetPush currently isn't open source - I don't think we've got converting it to dotnet core in the backlog yet.
A suggestion I've been discussing with the team is adding an error code to the beginning of the error message. The error code wouldn't be localized, so the string comparison would be valid. It'll be a few weeks until I can get that change deployed, but I'm willing to accept this change in the meantime.

Please bump the task version to 2.149.0

@ptrstpp950

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@jotaylo done and thank you!

@jotaylo jotaylo merged commit ff1f99a into microsoft:master Feb 28, 2019

4 checks passed

azure-pipelines-tasks.ci-linux #20190228.6 succeeded
Details
azure-pipelines-tasks.ci-macos #20190228.6 succeeded
Details
azure-pipelines-tasks.ci-windows #20190228.6 succeeded
Details
license/cla All CLA requirements met.
Details
@youfoundkris

This comment has been minimized.

Copy link

commented Mar 5, 2019

When will this be available on Azure DevOps?

@jotaylo

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

This will be part of the M149 deployment, which will be starting next week, but it might take a couple of weeks to get to you, depending on where your account is located.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.