Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Seeing Last Plan with Actual Plan Command #2663

Open
ambroselittle opened this issue Sep 21, 2018 · 10 comments
Open

Only Seeing Last Plan with Actual Plan Command #2663

ambroselittle opened this issue Sep 21, 2018 · 10 comments

Comments

@ambroselittle
Copy link

@ambroselittle ambroselittle commented Sep 21, 2018

  • SQL Operations Studio Version: Version 0.33.7-insider (0.33.7-insider)
  • macOS 10.13.6 (17G2307)

Also tried it on the current stable version. Actually, that's where I found it first..

Steps to Reproduce:

  1. Create a query window with > 1 queries.
  2. Use Run Current Query with Actual Plan command.

Actual:
Seems to cycle through the query plans in the Query Plan tab.
See: https://www.dropbox.com/s/jng6j59n7okxp0r/sqlops-actual-plan-bug.mov?dl=0

Expected:
Show them all, similar to Explain.

Maybe my expectations are just off?

@ambroselittle
Copy link
Author

@ambroselittle ambroselittle commented Nov 19, 2018

I can confirm this is still an issue in Version 1.2.4 (1.2.4).

This is more or less the only thing that keeps me having to run Parallels and SMS. Would love to see it fixed!

@kburtram
Copy link
Member

@kburtram kburtram commented Dec 11, 2018

This is basically the same issue as #1995. The problem is that showplan control we're using only renders one showplan XML document at a time.

If there are multiple statements within a batch then only a single XML showplan is returned for all the statements in the batch when getting the estimated plan. If there are multiple batches then one XML showplan is returned per-batch with estimated. With actual plans one XML document is returned per statement regardless of batches.

We have a couple different ideas how to resolve this limitation, but this isn't fixed in Dec release.

@mozart27
Copy link

@mozart27 mozart27 commented Apr 3, 2019

Is there any news on when this issue might be fixed?

@ambroselittle
Copy link
Author

@ambroselittle ambroselittle commented Apr 10, 2019

@kburtram, I'm not trying to be snarky, but the estimated shows multiple plans, so isn't this just a matter of swapping in the same control/code used on estimated for displaying actual? If you point me in the right direction, I'll submit a PR.

@jsmith8858
Copy link

@jsmith8858 jsmith8858 commented Apr 13, 2019

Any updates here? I agree with the prior post -- the code that displays the estimated plan clearly can render multiple plans in a list, surely this should be fairly easy to leverage the same code/technique for the actual plans?

@ambroselittle
Copy link
Author

@ambroselittle ambroselittle commented May 13, 2020

I have a whole horde of people at my company who'd jump to ADS if this one simple feature were fixed. Any update? Can I help/do you take PRs?

@kburtram
Copy link
Member

@kburtram kburtram commented Apr 23, 2021

@ambroselittle sorry I missed your previous comment (just looking through older issues today). If you're still interested in submitted a PR for this let me know and I can point you in the write direction. I think the fix may be a little more complicated than just swapping the estimated and actual code paths.

@ambroselittle
Copy link
Author

@ambroselittle ambroselittle commented Apr 26, 2021

@kburtram, yes. At least am willing to look at it.

@ambroselittle
Copy link
Author

@ambroselittle ambroselittle commented May 12, 2021

@kburtram, can ye point me in the right direction?

@kburtram
Copy link
Member

@kburtram kburtram commented May 12, 2021

@ambroselittle I'll put together some suggestions on how to fix this and reply back later today. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants