New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Contrast theme doubles/triples icons #2719

Closed
alxcm opened this Issue Sep 28, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@alxcm

alxcm commented Sep 28, 2018

  • Azure Data Studio Version: 1.0.0

The High Contrast theme included with Azure Data Studio, selectable by default with Ctrl+K Ctrl+T, doubles or triples the Run, Cancel, Disconnect, Change Connection, and Explain icons in the Taskbar, ironically making them harder to read. This can be fixed by removing

.hc-black .split-view-view .action-label {
    background: none;
}

from lines 646–648 of workbench.main.css, suggesting the theme is incompatible with that parameter.

@kburtram

This comment has been minimized.

Member

kburtram commented Oct 30, 2018

@alanrenmsft what do you think of the proposed fix?

@alanrenmsft

This comment has been minimized.

Contributor

alanrenmsft commented Oct 31, 2018

The logic behind the mentioned CSS class is to not show any icon in toolbar when HC theme is selected. but I don't see this rule in other parts of the product or VS Code. I think the proposed fix is acceptable. I will go ahead and make the change.

Thanks @alxcm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment