New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSeries chart does not render correctly. #2851

Closed
rgward opened this Issue Oct 15, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@rgward
Member

rgward commented Oct 15, 2018

  • Azure Data Studio Version: 1.0.0

Steps to Reproduce:

  1. Run the following query

select 'Counter', getdate(), 100
go

  1. Choose from the chart options TimeSeries

Nothing is displayed.

This has worked all the way up to August Public Preview 0.32.8. It appears to have broken starting with Sept Insiders Build 0.33.7

@kburtram kburtram added this to the November Release milestone Oct 16, 2018

@MattIrv

This comment has been minimized.

Member

MattIrv commented Oct 23, 2018

 ERR "timeSeries" is not a chart type.: Error: "timeSeries" is not a chart type.
    at Chart.<anonymous> (/Users/mairvine/code/sqlopsstudio/node_modules/chart.js/src/core/core.controller.js:336:13)
    at Object.each (/Users/mairvine/code/sqlopsstudio/node_modules/chart.js/src/helpers/helpers.core.js:108:9)
    at Chart.buildOrUpdateControllers (/Users/mairvine/code/sqlopsstudio/node_modules/chart.js/src/core/core.controller.js:318:12)
    at Chart.update (/Users/mairvine/code/sqlopsstudio/node_modules/chart.js/src/core/core.controller.js:391:28)
    at Graph.set [as data] (file:///Users/mairvine/code/sqlopsstudio/out/sql/parts/query/editor/charting/insights/graphInsight.js:108:34)
    at Graph.set [as options] (file:///Users/mairvine/code/sqlopsstudio/out/sql/parts/query/editor/charting/insights/graphInsight.js:190:27)
    at Insight.set [as options] (file:///Users/mairvine/code/sqlopsstudio/out/sql/parts/query/editor/charting/insights/insight.js:52:46)
    at ChartView.buildOptions (file:///Users/mairvine/code/sqlopsstudio/out/sql/parts/query/editor/charting/chartView.js:157:38)
    at Object.set (file:///Users/mairvine/code/sqlopsstudio/out/sql/parts/query/editor/charting/chartView.js:67:34)
    at file:///Users/mairvine/code/sqlopsstudio/out/sql/parts/query/editor/charting/chartView.js:227:63
    at Emitter.fire (file:///Users/mairvine/code/sqlopsstudio/out/vs/base/common/event.js:148:38)
    at HTMLSelectElement.<anonymous> (file:///Users/mairvine/code/sqlopsstudio/out/vs/base/browser/ui/selectBox/selectBoxNative.js:26:36)
@kburtram

This comment has been minimized.

Member

kburtram commented Oct 23, 2018

@anthonydresser when I run the repo with #2985 merged I see the below output. I would expect the x-axis to have the date value. Is this correct?

screen shot 2018-10-23 at 1 59 46 pm

@kburtram

This comment has been minimized.

Member

kburtram commented Oct 25, 2018

Now I see the below chart from the repro SQL. @rgward please reactive if this doesn't look as expected. I'll publish an updated build on Friday for further validation (or you can build the fix from master in the meantime).

screen shot 2018-10-24 at 6 28 40 pm

@kburtram kburtram closed this Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment