Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks: Converge on Better Way to Get Rows #4123

Open
chlafreniere opened this Issue Feb 22, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@chlafreniere
Copy link
Contributor

chlafreniere commented Feb 22, 2019

For the SQL kernel, we currently attempt to get all of the rows from a resultset in a synchronous manner. This has perf implications when resultsets get larger and larger, so we need to converge on a nice user experience here. For example, we could try to only get more rows from the resultset when a user starts to scroll.

In addition, we need to be mindful of the user experience for saving a notebook; we need to be explicit in how many rows we serialize, and surface that to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.