Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks: Converge on Better Way to Get Rows #4123

Closed
chlafreniere opened this issue Feb 22, 2019 · 1 comment
Closed

Notebooks: Converge on Better Way to Get Rows #4123

chlafreniere opened this issue Feb 22, 2019 · 1 comment

Comments

@chlafreniere
Copy link
Contributor

@chlafreniere chlafreniere commented Feb 22, 2019

For the SQL kernel, we currently attempt to get all of the rows from a resultset in a synchronous manner. This has perf implications when resultsets get larger and larger, so we need to converge on a nice user experience here. For example, we could try to only get more rows from the resultset when a user starts to scroll.

In addition, we need to be mindful of the user experience for saving a notebook; we need to be explicit in how many rows we serialize, and surface that to the user.

@chlafreniere chlafreniere added this to the March Release milestone Feb 22, 2019
@kevcunnane kevcunnane removed this from the March Release milestone Mar 6, 2019
@kevcunnane kevcunnane added this to the April Release milestone Mar 6, 2019
@chlafreniere chlafreniere removed this from the April Release milestone Apr 3, 2019
@chlafreniere chlafreniere added this to the May Release milestone Apr 3, 2019
@kburtram kburtram removed this from the May Release milestone Apr 3, 2019
@kburtram kburtram added this to the Planning milestone Apr 3, 2019
@kevcunnane kevcunnane removed this from the Planning milestone Jun 6, 2019
@kburtram kburtram added this to the Backlog milestone Jul 1, 2019
@corivera corivera removed this from the Backlog milestone Jan 6, 2020
@corivera corivera added this to the Planning milestone Jan 6, 2020
@kburtram kburtram removed this from the Planning milestone Jan 15, 2020
@kburtram kburtram added this to the Backlog milestone Jan 15, 2020
@chlafreniere
Copy link
Contributor Author

@chlafreniere chlafreniere commented Nov 6, 2020

Fixed by #12937.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants