Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks Save/Save All/Dirty/Caching #4290

rajmusuku opened this Issue Mar 5, 2019 · 0 comments


None yet
2 participants
Copy link

rajmusuku commented Mar 5, 2019

Here are the tracking items to implement save functionality in Notebooks

  • Implement Save/Save All for existing notebooks -> Open notebook and save
  • Implement Save As for existing notebooks -> Open notebooks and save as
  • Implement Save/Save All for untitled notebooks -> Create a new notebook and save/save all
  • Implement Save As for untitled notebooks -> Create a new notebook and save as
  • Add 'confirmSave' feature for all the notebooks. save dialog should be prompted while closing a dirty notebook
  • Implement dirty notebooks
  • Implement caching notebooks when relaunching ADS
  • Add/Fix unit tests in notebook model
  • Refactor NotebookEditorModel being passed as a separate object to NotebookInput. This needs to be handled in NotebookInput itself.
  • Refactor NotebookManager/ LocalContentManager stuff
  • Cleanup existing model save as we have native file save implemented

@rajmusuku rajmusuku added the notebooks label Mar 5, 2019

@rajmusuku rajmusuku added this to the March Release milestone Mar 5, 2019

@rajmusuku rajmusuku self-assigned this Mar 5, 2019

rajmusuku added a commit that referenced this issue Mar 7, 2019

rajmusuku added a commit that referenced this issue Mar 8, 2019

#3920: Notebooks file save/save all/cache - for existing files (#4286)
* #3920: Notebooks file save

* Missed in merge

* #4290: Untitled save and native dirty implementation

* Misc changes

* Content Manager, notebooks extension and commented failed unit tests

* Removing modelLoaded event

@kevcunnane kevcunnane closed this Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.