New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tempdb spool warnings in Explain view #725

Closed
justingrant opened this Issue Feb 17, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@justingrant
Copy link

justingrant commented Feb 17, 2018

One feature I miss from SQL Management Studio is the yellow triangle warning icons in the query plan.

In particular, I'd like to see the spool warning for an actual plan so I can identify problems with cardinality estimation in earlier operators.

@JustinPealing

This comment has been minimized.

Copy link

JustinPealing commented Feb 20, 2018

Do you mean these warnings?

image

If so this is JustinPealing/html-query-plan#63, which is in v2.4 of html-query-plan.

@justingrant

This comment has been minimized.

Copy link
Author

justingrant commented Feb 20, 2018

@JustinPealing that is exactly what I was talking about. Does JustinPealing/html-query-plan#63 show a warning icon or just the warning text in the tooltip?

@JustinPealing

This comment has been minimized.

Copy link

JustinPealing commented Feb 20, 2018

There are warning icons, although they don't stand out against the node icons particularly well in some cases

image

@kburtram

This comment has been minimized.

Copy link
Member

kburtram commented Feb 20, 2018

@anthonydresser do you know how I can upgrade html_query_plan to 2.4? Do I need to merge JustinPealing/html-query-plan into anthonydresser/html-query-plan then bump our package.json to #2.4?

@kburtram kburtram added the showplan label Feb 20, 2018

@anthonydresser

This comment has been minimized.

Copy link
Member

anthonydresser commented Feb 20, 2018

It's a little more involved than that, I can just do it real quick

@kburtram

This comment has been minimized.

Copy link
Member

kburtram commented Feb 20, 2018

Thanks @anthonydresser! Please document the process somewhere (or walk me through the process) if you don't want to be the only on-going owner of this step.

@kburtram

This comment has been minimized.

Copy link
Member

kburtram commented Mar 7, 2018

We updated to html-query-plan 2.4 so I think this will be fixed in the next March Insiders build that I'll publish next week. Please reactive if this is still in issue in that build (or in a private build from master if you can't wait for that build 😄).

@kburtram kburtram closed this Mar 7, 2018

@LitKnd

This comment has been minimized.

Copy link

LitKnd commented Aug 3, 2018

I found this while looking to file a bug on this very issue -- I am not seeing the warning icons on plans in SQL Ops Studio today. Attached is a gif showing code with the warning on the sort operator in SSMS, then the same code with no warning on the sort in Ops Studio.

You can see that there was a spill from the tooltip in Ops Studio, but there is no warning indication on the operator, but practically speaking most plans are complex enough that the operator level visual indication is needed to draw attention.

Repro code to cause the spill...

`declare @foo table (i int);

WITH Ten(N) AS
(
SELECT 1 UNION ALL SELECT 1 UNION ALL SELECT 1 UNION ALL
SELECT 1 UNION ALL SELECT 1 UNION ALL SELECT 1 UNION ALL
SELECT 1 UNION ALL SELECT 1 UNION ALL SELECT 1 UNION ALL SELECT 1
)
insert @foo
SELECT T1000000.N
FROM Ten T10
CROSS JOIN Ten T100
CROSS JOIN Ten T1000
CROSS JOIN Ten T10000
CROSS JOIN Ten T100000
CROSS JOIN Ten T1000000;

select 0
FROM @foo
ORDER BY i DESC`

no warnings on sort operator with spill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment