New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kenvh/editdatatabname #2906

Merged
merged 3 commits into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@kenvanhyning
Contributor

kenvanhyning commented Oct 16, 2018

edit data was escaping the doc URI - this isn't necessary. The SMO code is doing necessary escaping for scripting functions.

This change removes the escaping so that the tab has a clean name and refactored slightly the code used to create the editor names.

@kenvanhyning kenvanhyning requested a review from kburtram Oct 16, 2018

@kenvanhyning kenvanhyning self-assigned this Oct 16, 2018

private createEditDataFileName(tableName: string): string {
let editDataFileName = (counter: number): string => {
return encodeURIComponent(`${tableName}_${counter}`);
private createPrefixedSqlFilePlath(prefix: string): string {

This comment has been minimized.

@MattIrv

MattIrv Oct 16, 2018

Member

typo here: "plath"

@kenvanhyning

This comment has been minimized.

Contributor

kenvanhyning commented Oct 18, 2018

CI failure is unrelated to changes

@kenvanhyning kenvanhyning merged commit 8a57006 into master Oct 18, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment