Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DialogSet.SetTelemetryClient(), and modify ComponentDialog #1210

Merged
merged 4 commits into from Dec 5, 2018

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Dec 3, 2018

Incorporate Feedback from @Stevenic:

This enables ComponentDialog to set the TelemetryClient and updates all the underlying dialog's TelemetryClient

  • Add DialogSet.TelemetryClient which will set the telemetryClient on all contained dialogs.
  • Modify DialogSet.Add to set the TelemetryClient property on the dialog being added.
  • Modify setter on ComponentDialog.TelemetryClient to set contained dialogs.
  • Modify ComponentDialog.Add to set TelemetryClient property on the dialog being added.

@coveralls
Copy link
Collaborator

coveralls commented Dec 3, 2018

Pull Request Test Coverage Report for Build 44820

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 55.687%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Dialog.cs 9 67.86%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogSet.cs 10 77.55%
/libraries/Microsoft.Bot.Builder.Dialogs/ComponentDialog.cs 19 70.11%
Totals Coverage Status
Change from base Build 44745: 0.1%
Covered Lines: 5479
Relevant Lines: 9839

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants