Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #407: Removed AppBar, OperatorTextBox and OperandTextBox controls #440

Merged
merged 5 commits into from Apr 17, 2019

Conversation

Projects
None yet
5 participants
@jatinkumarg
Copy link
Contributor

commented Apr 5, 2019

Removed AppBar, OperatorTextBox and OperandTextBox controls

@msftclas

This comment has been minimized.

Copy link

commented Apr 5, 2019

CLA assistant check
All CLA requirements met.

@danbelcher-MSFT danbelcher-MSFT self-assigned this Apr 11, 2019

@jatinkumarg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

@danbelcher-MSFT My recent commit got TF400898: An Internal Error Occurred. (https://dev.azure.com/ms/calculator/_build/results?buildId=10301&view=results)

Do you know if it's because of my code or azure server issue?

@danbelcher-MSFT

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

I'm not sure. You can go to the 'Checks' tab and re-run the check:
image

@jatinkumarg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

It doesn't give me an option to re-run. If possible can you give me authority to re-run it or just re-run it on my behalf?

image

@danbelcher-MSFT

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

I had already tried re-running for you but the build has been queued for 17 minutes now. We think the PR hit a bug in Azure Pipelines. We'll contact the team tomorrow to do more investigation. Sorry about the trouble!

@mcooley

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Closing and reopening to hopefully get the pipeline out of a bad state...

@mcooley mcooley closed this Apr 12, 2019

@mcooley mcooley reopened this Apr 12, 2019

@danbelcher-MSFT

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@jatinkumarg, looks like the build works now. You have some build errors to fix and then we can get your change merged. Thanks @mcooley!

@jatinkumarg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

@danbelcher-MSFT Everything seems fine now. Let me know if there are any further changes required.

@danbelcher-MSFT danbelcher-MSFT merged commit c150cd4 into microsoft:master Apr 17, 2019

6 checks passed

Calculator-CI Build #0.1904.1203.0 succeeded
Details
Calculator-CI (Build x64) Build x64 succeeded
Details
Calculator-CI (CleanUpUnitTestsx64) CleanUpUnitTestsx64 succeeded
Details
Calculator-CI (Package) Package succeeded
Details
Calculator-CI (UnitTests x64) UnitTests x64 succeeded
Details
license/cla All CLA requirements met.
Details

EriWong added a commit to EriWong/calculator that referenced this pull request Jun 5, 2019

Removed AppBar, OperatorTextBox and OperandTextBox controls (microsof…
…t#440)

Fixes microsoft#407 
Removed AppBar, OperatorTextBox and OperandTextBox controls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.