New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around SSL compression methods memory leak in ASIO #143

Merged
merged 50 commits into from Jun 8, 2016

Conversation

Projects
None yet
@vadz
Contributor

vadz commented May 6, 2016

Call SSL_COMP_free_compression_methods() because ASIO itself doesn't, even
though it should, because it calls SSL_library_init() which allocates memory
for the compression methods.

Closes #67


This is ugly but seems like the only way to fix the annoying leak reports other than fixing the bug in ASIO itself, but considering that Casablanca still uses Boost 1.55, I'm not sure how soon will it get this fix even if it does get fixed upstream.

AntonBikineev and others added some commits Jan 6, 2016

Added prefix to credentials to avoid compilation errors on Linux conf…
…using with krb5.h struct credentials declaration
Merge pull request #70 from leighsmith/development
Added prefix to credentials to avoid compilation errors on Linux
Fix use after free in HTTPS listener on non-windows.
The boost examples for ssl::stream all use stack allocated contexts and
streams; considering that the ssl::context is noncopyable, it seems that
its lifetime must exceed any streams.
Fix typo hexidecimal/hexadecimal
Spotted by debian lintian checks
Merge pull request #114 from leighsmith/xcode7.3
Removed redundant std::move() that was causing errors on Xcode 7.3 gcc
Merge pull request #116 from pp555/fix-latin1-convertion
Fixing latin1 to UTF-16 convertion

ras0219 and others added some commits Apr 3, 2016

Code review comments for 952a0e22
Conflicts:
	Release/src/http/client/http_client.cpp
Merge branch 'http-pipeline-refactor' into development
Conflicts:
	Release/src/http/common/http_helpers.cpp
Improve CMake support for windows.
Added experimental support for building UWP.
Added support for accessing NuGet packages.
Renamed project to 'cpprest'.
Removed superfluous ${LIB} prefix on all libs.
Enabled MultiToolTask for android build.
Added header files to the cpprest library, improving IDE support.
Merge branch 'improve-buildsystem' into development
Conflicts:
	Release/CMakeLists.txt
	Release/src/CMakeLists.txt
Update to include access control allow origin
added DAT(access_control_allow_origin,  "Access-Control-Allow-Origin") as a list of header items.
Merge pull request #131 from jsonng/patch-1
Update to include access control allow origin
@msftclas

This comment has been minimized.

msftclas commented May 6, 2016

Hi @vadz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@ras0219-msft

This comment has been minimized.

Contributor

ras0219-msft commented May 6, 2016

Thank you for this PR. I think this is probably a good fix for the time being.

Two changes though:

  1. Please make the PR against the development branch
  2. We only use ASIO on windows for websockets, so this should probably go into Release/src/websockets/client/ws_client_wspp.cpp. The only platform that doesn't pull in that file is WinRT, which doesn't use ASIO.
@msftclas

This comment has been minimized.

msftclas commented May 6, 2016

@vadz, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@msftclas msftclas added cla-signed and removed cla-required labels May 6, 2016

Work around SSL compression methods memory leak in ASIO
Call SSL_COMP_free_compression_methods() because ASIO itself doesn't, even
though it should, because it calls SSL_library_init() which allocates memory
for the compression methods.

Closes #67
@vadz

This comment has been minimized.

Contributor

vadz commented May 6, 2016

@ras0219-msft Thanks for your quick review! I've updated the PR and retested to confirm that it still fixes the problem.

@ras0219-msft ras0219-msft merged commit 29116a7 into Microsoft:master Jun 8, 2016

@nathan-gilbert

This comment has been minimized.

nathan-gilbert commented Aug 4, 2016

I tried a build of the current development branch and it didn't fix the memory leaks. Only by defining CPPREST_EXCLUDE_WEBSOCKETS was I able to stop them. Is there something I'm missing regarding the fix mentioned above regarding the ASIO memory leaks?

jasonsandlin added a commit to jasonsandlin/cpprestsdk that referenced this pull request Nov 5, 2016

Squashed commit of the following:
commit eee6bea
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Oct 18 12:30:28 2016 -0700

    Update ThirdPartyNotices.txt to only cover websocketpp, since boost and openssl are not checked in

commit 1d03de5
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Oct 18 12:27:38 2016 -0700

    Update license to MIT

commit 9aed8c3
Merge: edfb941 c873d63
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Thu Oct 13 09:33:44 2016 -0700

    Merge branch 'clang38' into development

commit c873d63
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Oct 5 12:07:01 2016 -0700

    Revert temporary changes from cpprestsdk140.sln

commit 5214d5e
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Oct 5 11:40:47 2016 -0700

    Change ApplicationTypeRevision=2.0 for VS Update3 to use the clang 3_8
    toolset.

commit 0cc46e8
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Oct 5 10:22:13 2016 -0700

    Update the Nuget package paths to use the android packages built with
    clang 3_8

commit d133746
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Oct 5 10:13:12 2016 -0700

    Some fixes to build with clang 3_8.
    Ignore the -Winfinite-recursion warning. This has been fixed in the next
    boost versions.

commit 2902b29
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Tue Oct 4 16:10:18 2016 -0700

    Android build script updates to use NDK 11 and clang 3.8

commit 26bf780
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Mon Sep 26 10:07:31 2016 -0700

    Fixes to build with clang 3_8

commit edfb941
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Thu Aug 25 18:13:42 2016 -0700

    Bump version to 2.9

commit abc2753
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Fri Aug 5 15:11:11 2016 -0700

    Reduce size of race condition in asio_client. In the future, the entire timeout interaction needs to be reworked to remove it entirely.

commit 2e99d10
Author: Casablanca Team <askcasablanca@microsoft.com>
Date:   Thu Aug 4 14:40:37 2016 -0700

    During timeout, there is a race to determine the exact error code. To ensure timeouts always result in std::errc::timed_out, we trigger entirely off of the timer's state instead of considering the error code.

commit 7224d35
Merge: 4d52eae c800ab2
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Tue Aug 2 17:48:30 2016 -0700

    Merge pull request Microsoft#217 from daniuk-microsoft/daniuk/ws_client_winrt/race_condition_fix

    Fixed race condition in Casablanca ws_client_winrt.cpp

commit 4d52eae
Merge: 21eda51 6cd6392
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Tue Aug 2 14:48:32 2016 -0700

    Merge branch 'dev/roschuma/host_based_connection_pool' into development

commit c800ab2
Author: daniuk-microsoft <daniuk@microsoft.com>
Date:   Tue Aug 2 11:38:02 2016 -0700

    Fixed race condition in Casablanca ws_client_winrt.cpp

    Fixed race condition in Casablanca ws_client_winrt.cpp
    - Simplified message queuing logic to always use the outgoing queue
    - Removed m_num_sends member variable

commit 6cd6392
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Aug 2 00:46:54 2016 -0700

    Revert global connection pool, but leave improved individual pools. Pools no longer need to self-reference and are destroyed with the owning http_client.

commit 21eda51
Merge: 5b7bfd4 211fdea
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Fri Jul 29 16:02:29 2016 -0700

    Merge branch 'dev/kavyako/fix_websocket_tests' into development

commit 211fdea
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Fri Jul 29 16:00:38 2016 -0700

    Fix websocket tests. jabbr.net certificate is not valid anymore.
    swordsoftruth.com certificate has been fixed. so interchange the sites in
    the tests.

commit 5b7bfd4
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Thu Jul 28 13:17:35 2016 -0700

    Fix a typo error from previous commit

commit 16582a5
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Thu Jul 28 13:05:16 2016 -0700

    Fix warning 4996 for get_env for 120 samples

commit ad9150b
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Thu Jul 28 13:00:41 2016 -0700

    Fix bingrequest build break on osx and linux

commit 0bed9f9
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Thu Jul 28 11:21:59 2016 -0700

    Disable create_https_listener_get testcase

commit 4b8b0fe
Merge: 47689b3 c7c044f
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Jul 27 16:27:52 2016 -0700

    Merge branch 'feelapi-staticxp' into development

commit 47689b3
Merge: 9e9bcbe 525db49
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Jul 27 15:30:00 2016 -0700

    Merge branch 'hyotak-yun-master' into development

commit 9e9bcbe
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Jul 27 15:14:28 2016 -0700

    Fix compile errors on windows

commit 37df2d3
Merge: 08bf1a7 02119a1
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Jul 27 13:40:40 2016 -0700

    Merge pull request Microsoft#206 from ajneu/development_headers_proxy

    remove warnings-errors for system-headers under linux; honour http_proxy env-variable

commit 08bf1a7
Merge: 283ec85 f35ebf5
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Jul 27 13:35:10 2016 -0700

    Merge branch 'ritzk-basic_auth_asio' into development

commit f35ebf5
Merge: 283ec85 526e997
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Jul 27 13:34:58 2016 -0700

    Merge branch 'basic_auth_asio' of https://github.com/ritzk/cpprestsdk into ritzk-basic_auth_asio

commit 283ec85
Merge: bdb3db6 08f5900
Author: Kavya Kotacherry <kavyako@microsoft.com>
Date:   Wed Jul 27 13:25:24 2016 -0700

    Merge branch 'dev/roschuma/host_based_connection_pool' into development

commit bdb3db6
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Jul 26 16:47:16 2016 -0700

    Adopt the Microsoft Open Source Code of Conduct

commit 08f5900
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Mon Jul 25 15:10:25 2016 -0700

    When the epoch has not increased since the last cleanup cycle, it means we can clear the pool, not that the pool is empty.

commit 02119a1
Author: ajneu <ajneu@users.noreply.github.com>
Date:   Tue Jul 19 20:31:06 2016 +0200

    have BingRequest honour http_proxy environment variable

commit 943aa0b
Author: ajneu <ajneu@users.noreply.github.com>
Date:   Tue Jul 19 20:30:04 2016 +0200

    include_directories with SYSTEM for system-headers such as boost, to avoid warnings-checking on those 3rd party headers

commit eaacac4
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Jul 5 15:45:37 2016 -0700

    Improved asio connection pooling implementation.

    Removed asio_connection inherits from enable_shared_from_this.
    Replaced asio_connection_pool::m_parent_pool_cb with a self-referencing shared_ptr.
    Added asio_shared_connection_pool::m_timer to periodically clear out expired connection pools.

commit 0b7fd42
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Thu Jun 30 02:54:10 2016 -0700

    Merged connection deadline_timers, reverted solution back to pool of pools approach

commit 89c20dd
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Jun 28 18:23:23 2016 -0700

    WIP

commit 526e997
Author: Ritesh Khadgaray <khadgaray@gmail.com>
Date:   Sun Jun 26 13:58:09 2016 +0530

    asio basic auth support: test case

commit a3b7165
Author: Ritesh Khadgaray <khadgaray@gmail.com>
Date:   Sun Jun 26 11:24:57 2016 +0530

    add support for basic authentication

commit e9667db
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Fri Jun 24 05:46:04 2016 +0000

    remove pool_map, use multimap in global connection_pool

commit e29426d
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Fri Jun 17 08:19:37 2016 +0000

    use iterator in free_connection_pool

commit 5caac19
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Tue Jun 14 08:50:37 2016 +0000

    move connection_pool_map related functions from threadpool to http_client_asio

commit ca5cf69
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Mon Jun 13 16:58:07 2016 +0000

    remove unnecessary lock

commit 2dd31c1
Merge: 943c4d8 e8b3509
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Mon Jun 13 09:11:53 2016 +0000

    Merge remote-tracking branch 'upstream/development' into host_based_connection_pool

commit 943c4d8
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Mon Jun 13 09:11:45 2016 +0000

    add pool timer to clean connection pool

commit e8b3509
Merge: d79c9a0 12619af
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Jun 8 16:06:56 2016 -0700

    Merge pull request Microsoft#143 from vadz:asio-mem-leak-fix

commit d79c9a0
Merge: 944daa7 8e09ae6
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Jun 7 13:31:41 2016 -0700

    Merge pull request Microsoft#149 from hanzhumsft/uri_perf_improvements

    Some perf improvements for uri related code

commit 944daa7
Author: Alexander Karatarakis <alkarata@microsoft.com>
Date:   Thu Jun 2 18:45:59 2016 -0700

    Add nullcheck to eliminate warning with Code Analysis

commit 0b4359b
Merge: 72aaec6 11a53da
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue May 31 16:17:01 2016 -0700

    Merge pull request Microsoft#117 from slepasteur/development

    Fix header reading on linux listener using HTTPS.

commit 72aaec6
Merge: 5f0b315 2501bfc
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Mon May 23 15:27:47 2016 -0700

    Merge branch 'stewartbright-header-fix' into development

commit 2501bfc
Merge: 5f0b315 4f9a550
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Mon May 23 15:27:22 2016 -0700

    Merge branch 'header-fix' of https://github.com/stewartbright/cpprestsdk into stewartbright-header-fix

commit 4f9a550
Author: Stewart Bright <stewart.bright@gmail.com>
Date:   Wed May 18 20:57:55 2016 -0400

    Header parsing assumes whitespace after colon

    Not sure how, but fix line was deleted rather than committed.

commit b6f2037
Author: Stewart Bright <stewart.bright@gmail.com>
Date:   Wed May 18 15:54:30 2016 -0400

    Header parsing assumes whitespace after colon

    RFC7230 (HTTP 1.1) 3.2 "Header fields" specifies that whitespace between
    colon and value is optional, but http_client_asio::read_headers started
    reading the value at one after the colon, assuming there would always be
    exactly one space.

commit 02b8718
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Wed May 18 05:42:41 2016 +0000

    if ssl_context_callback is used, then the pool is not added to the map

commit 8e09ae6
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Wed May 18 03:45:46 2016 +0000

    fixed 2 unit tests
    uri_builder_tests:to_string_invalid_uri
    uri_builder_tests:append_query_locale

commit 6e23e69
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Thu May 12 05:58:48 2016 +0000

    add host based connection pool map

commit 5f0b315
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Thu May 12 12:20:31 2016 -0700

    Fix renamed argument under CPPREST_STDLIB_UNICODE_CONVERSIONS. Fixes Microsoft#153.

commit 9d8a739
Merge: 787bd82 2d26f0a
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue May 10 17:24:57 2016 -0700

    Merge Pull Request Microsoft#115

commit 787bd82
Merge: 1e0b5c5 dad1c14
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue May 10 16:45:19 2016 -0700

    Merge Pull Request Microsoft#137

commit 5c95411
Merge: 1e0b5c5 5df687f
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Tue May 10 05:55:12 2016 +0000

    Merge perf improvements for uri related code into uri_perf_improvements

commit 5df687f
Author: Han Zhu <hanzhu@microsoft.com>
Date:   Wed May 4 08:48:22 2016 +0000

    some perf improvements for uri related code

commit 12619af
Author: Vadim Zeitlin <vz-casablanca@zeitlins.org>
Date:   Fri May 6 23:27:19 2016 +0200

    Work around SSL compression methods memory leak in ASIO

    Call SSL_COMP_free_compression_methods() because ASIO itself doesn't, even
    though it should, because it calls SSL_library_init() which allocates memory
    for the compression methods.

    Closes Microsoft#67

commit dad1c14
Author: Deniz Türkoglu <turkoglu.deniz@gmail.com>
Date:   Wed Apr 27 09:10:00 2016 +0200

    Enable builds on OSX

    Remove hardcoded platform strings with variables and fix scripts
    to work on both OSX and Linux.

commit d5afb5c
Author: Deniz Turkoglu <turkoglu.deniz@gmail.com>
Date:   Sun Apr 24 10:21:31 2016 +0200

    Fix android build script for linux

    The build no longer uses libiconv but there were traces left. Also
    boost patch had a typo for x86. With these changes, the build script
    should work as expected.

commit 1e0b5c5
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Apr 20 18:16:55 2016 -0700

    Remove Windows-On-Devices and android test runner from the default solution file.

commit b61cbe1
Merge: 45ff2f6 7ff0685
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Apr 20 18:05:23 2016 -0700

    Merge pull request Microsoft#131 from jsonng/patch-1

    Update to include access control allow origin

commit 7ff0685
Author: Jason Ng <black1999bmw@YAHOO.COM>
Date:   Sun Apr 17 15:14:13 2016 -0700

    Update to include access control allow origin

    added DAT(access_control_allow_origin,  "Access-Control-Allow-Origin") as a list of header items.

commit 45ff2f6
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Thu Apr 14 16:35:00 2016 -0700

    Remove extraneous allocation of boost::asio::ssl::stream

commit 5abe0cb
Merge: 54d7fcd 834491e
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Thu Apr 14 03:07:18 2016 -0700

    Merge branch 'improve-buildsystem' into development

    Conflicts:
    	Release/CMakeLists.txt
    	Release/src/CMakeLists.txt

commit 834491e
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Apr 12 15:45:17 2016 -0700

    Improve CMake support for windows.

    Added experimental support for building UWP.
    Added support for accessing NuGet packages.
    Renamed project to 'cpprest'.
    Removed superfluous ${LIB} prefix on all libs.
    Enabled MultiToolTask for android build.
    Added header files to the cpprest library, improving IDE support.

commit 54d7fcd
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Thu Apr 14 00:39:04 2016 -0700

    Mark add_handler std::function argument as requiring __cdecl to guard against compiler options

commit b332591
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Apr 13 23:37:56 2016 -0700

    Fix move of http_pipeline into web::http::client namespace

commit 621f0da
Merge: f4c8a47 479ebe7
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Apr 13 23:29:19 2016 -0700

    Merge branch 'http-pipeline-refactor' into development

    Conflicts:
    	Release/src/http/common/http_helpers.cpp

commit 479ebe7
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Tue Apr 12 10:49:42 2016 -0700

    Code review comments for 952a0e22

    Conflicts:
    	Release/src/http/client/http_client.cpp

commit ba2adb3
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Mon Apr 4 18:38:49 2016 -0700

    http_pipeline does not have correct semantics under move.

commit baa8c9b
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sun Apr 3 03:17:52 2016 -0700

    Add final for internal types. Fix docs.

commit 98320fe
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Apr 13 23:11:31 2016 -0700

    Hide definition of http_pipeline.

commit f4c8a47
Merge: 1c4171b fde3e9a
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Apr 13 23:01:29 2016 -0700

    Merge branch fix-https-linux into development

commit fde3e9a
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Apr 13 20:17:57 2016 -0700

    Update tests to account for outside site fixing bad certificate.

commit 7c9189e
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Mon Apr 4 20:22:58 2016 -0700

    Fix android build after refactor.

commit aff4a1a
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sun Apr 3 01:11:28 2016 -0700

    Refactor to remove web::http::details::http_network_handler.

commit a0a0f8d
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sat Apr 2 22:11:24 2016 -0700

    Refactor http_client_impl.h to be internal.

commit d3391c8
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sat Apr 2 19:59:47 2016 -0700

    http_helpers only uses string_t.

commit 9b5ecb1
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sat Apr 2 19:58:53 2016 -0700

    Move mime_types and charset_types to the header matching the defining cpp

commit 9869462
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sat Apr 2 19:50:33 2016 -0700

    Localized conversion functions from http_helpers.h to http_msg.cpp

commit 6f5f815
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sat Apr 2 19:42:33 2016 -0700

    Move definitions from http_helpers into http_msg, removing external declarations

commit 2b79bd3
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sat Apr 2 19:10:36 2016 -0700

    Declaration for verify_x509_cert_chain does not need external linkage.

commit dac2c16
Author: Robert Schumacher <ras0219@outlook.com>
Date:   Sat Apr 2 19:07:14 2016 -0700

    Consolidate x509's into a single file. No need to have a file per (mutually exclusive) function.

commit 11a53da
Author: Simon Lepasteur <simon.lepasteur@swissdotnet.ch>
Date:   Tue Apr 5 11:36:08 2016 +0200

    Modify create_https_listener_get test to check that headers and body are retrieved correctly.

commit 1c4171b
Merge: 29ba42e 5d84d4c
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Thu Mar 31 14:30:12 2016 -0700

    Merge pull request Microsoft#116 from pp555/fix-latin1-convertion

    Fixing latin1 to UTF-16 convertion

commit a148540
Author: Simon Lepasteur <simon.lepasteur@swissdotnet.ch>
Date:   Thu Mar 31 16:36:20 2016 +0200

    Fix header reading on linux listener using HTTPS.

    The first asynchronous read of the stream was stopping at the first CRLF (after the HTTP version) instead of reading until CRLFCRLF (the end of the header).

    This bug was not always noticeable because, as stated in the boost documentation:
    "After a successful async_read_until operation, the streambuf may contain additional data beyond the delimiter. An application will typically leave that data in the streambuf for a subsequent async_read_until operation to examine."
    Therefore the bug appeared only when trying to read the body of the request and the streambuf filled by async_read_until did not contain the complete header.

commit 5d84d4c
Author: pp555 <piotrek555@gmail.com>
Date:   Wed Mar 23 16:12:46 2016 +0100

    Fixing latin1 to UTF-16 convertion

commit 29ba42e
Merge: fb4aba9 f063765
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Mar 30 18:33:12 2016 -0700

    Merge pull request Microsoft#114 from leighsmith/xcode7.3

    Removed redundant std::move() that was causing errors on Xcode 7.3 gcc

commit 2d26f0a
Author: Rami Abughazaleh <icnocop@noreply.users.github.com>
Date:   Wed Mar 30 15:01:22 2016 -0700

    Added projects which target v140_xp to resolve Microsoft#113

commit fb4aba9
Merge: 43c1c87 2bf31b7
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Mar 30 17:36:34 2016 -0700

    Merge pull request Microsoft#82 from dogukan/master

commit 43c1c87
Merge: 356639d 0d615a1
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Mar 30 17:32:20 2016 -0700

    Merge pull request Microsoft#86 from schellap/patch-1

commit 356639d
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Mar 30 17:26:26 2016 -0700

    Adding 'lib' prefix to v140 static lib to prevent collision with import lib name

commit a13c132
Merge: 42d6366 58c1a64
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Mar 30 17:21:59 2016 -0700

    Resolved merge conflicts with PR Microsoft#71

commit 42d6366
Merge: 5f75ec9 2b7b52f
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Wed Mar 30 17:12:59 2016 -0700

    Merge pull request Microsoft#96 from locutus/patch-2

commit f063765
Author: Leigh Smith <leigh@leighsmith.com>
Date:   Wed Mar 30 16:50:08 2016 -0400

    Removed redundant std::move() that was causing errors on Xcode 7.3 gcc

commit c7c044f
Author: feelapi <feelapi@gmail.com>
Date:   Wed Mar 30 16:36:21 2016 +0800

    add static library for windows xp

commit 525db49
Author: hyotak.yun <hyotak.yun@nhnent.com>
Date:   Wed Mar 23 20:01:56 2016 +0900

    .

commit d6b882a
Author: hyotak.yun <hyotak.yun@nhnent.com>
Date:   Wed Mar 23 19:56:47 2016 +0900

    Added websocket_client_config option for ssl verify mode

commit 2b7b52f
Author: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
Date:   Thu Mar 17 08:32:42 2016 +0100

    Fix typo hexidecimal/hexadecimal

    Spotted by debian lintian checks

commit 0d615a1
Author: Senthil <schellap@microsoft.com>
Date:   Wed Mar 9 01:11:10 2016 -0800

    Fix obtaining raw string_t pointer from temporary

commit ef8e748
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Fri Mar 4 16:16:16 2016 -0800

    Fix use after free in HTTPS listener on non-windows.

    The boost examples for ssl::stream all use stack allocated contexts and
    streams; considering that the ssl::context is noncopyable, it seems that
    its lifetime must exceed any streams.

commit 2bf31b7
Author: Doğukan Çağatay <dogukan.cagatay@esensi.com.tr>
Date:   Thu Mar 3 16:27:51 2016 +0200

    Fixed ambiguous call to begin when using with boost library.

commit 5f75ec9
Merge: 9052811 2e23b2a
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Thu Mar 3 01:39:31 2016 -0800

    Merge pull request Microsoft#47 from anton/fixing#418

commit 2e23b2a
Author: AntonBikineev <ant.bikineev@gmail.com>
Date:   Wed Mar 2 03:56:16 2016 -0600

    Adding decay to noncopyablefunctorwrapper

commit cd97141
Author: AntonBikineev <ant.bikineev@gmail.com>
Date:   Tue Mar 1 08:29:20 2016 -0600

    Fixing noncopyablewrapper ctor

commit 7a07d38
Merge: ff4f311 9052811
Author: AntonBikineev <ant.bikineev@gmail.com>
Date:   Tue Mar 1 08:28:24 2016 -0600

    Merge branch 'development' into fixing#418

commit ff4f311
Author: AntonBikineev <ant.bikineev@gmail.com>
Date:   Sun Feb 28 03:04:12 2016 +0300

    Disabling movable_then test on Windows

commit 2320e0c
Author: AntonBikineev <ant.bikineev@gmail.com>
Date:   Sat Feb 27 22:08:26 2016 +0300

    Changing use of C++14 capture initialization to usual functor in pplxtask_tests.hpp

commit 9052811
Merge: f15910c 01e3eff
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Fri Feb 26 13:54:32 2016 -0800

    Merge pull request Microsoft#70 from leighsmith/development

    Added prefix to credentials to avoid compilation errors on Linux

commit f15910c
Merge: 3070ca2 8b6f832
Author: Robert Schumacher <roschuma@microsoft.com>
Date:   Fri Feb 26 13:51:58 2016 -0800

    Merge pull request Microsoft#65 from snikulov/linux_build_fix

    Fixed build on CentOS 7 Linux

commit 58c1a64
Author: Justin Marshall <j.marshall@oodrive.fr>
Date:   Tue Feb 9 17:21:50 2016 +0100

    Add a project for compiling as a static lib

commit 01e3eff
Author: Leigh Smith <leigh@leighsmith.com>
Date:   Mon Feb 8 22:10:31 2016 -0500

    Added prefix to credentials to avoid compilation errors on Linux confusing with krb5.h struct credentials declaration

commit 8b6f832
Author: Sergei Nikulov <sergey.nikulov@gmail.com>
Date:   Tue Feb 2 12:41:20 2016 +0300

    fix for build on Linux

commit e708c1a
Author: AntonBikineev <ant.bikineev@gmail.com>
Date:   Wed Jan 6 04:02:31 2016 +0300

    Fixing .then to work with movable-only types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment