New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic auth asio on Linux #97

Closed
wants to merge 2 commits into
base: testing
from

Conversation

Projects
None yet
4 participants
@ritzk
Contributor

ritzk commented Mar 17, 2016

Add support for basic auth for http_client_asio on Linux

    auto creds = web::http::client::credentials(user, password);
    client_config.set_credentials(creds);

    m_client = std::unique_ptr<web::http::client::http_client > \
        (new web::http::client::http_client (server, client_config));

    auto task = m_client->request(web::http::methods::POST, api_path);
    task.then([](web::http::http_response response) {
        std::cout << "response is " << response.to_string()  << "\n";
    });
    task.wait();
@msftclas

This comment has been minimized.

msftclas commented Mar 17, 2016

Hi @ritzk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas

This comment has been minimized.

msftclas commented Mar 17, 2016

@ritzk, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@msftclas msftclas added cla-signed and removed cla-required labels Mar 17, 2016

@msftclas

This comment has been minimized.

msftclas commented Mar 19, 2016

@ritzk, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@msftclas msftclas added the cla-signed label Mar 19, 2016

@ras0219-msft

This comment has been minimized.

Contributor

ras0219-msft commented Mar 31, 2016

This looks solid. However, in order to merge, we will need to enable our basic auth tests to cover Linux as well.

@ritzk

This comment has been minimized.

Contributor

ritzk commented Jul 8, 2016

test case added.

@kavyako

This comment has been minimized.

Contributor

kavyako commented Jul 27, 2016

Merged to development. The changes will be in the 2.9 release.

@kavyako kavyako closed this Jul 27, 2016

@moozzyk moozzyk referenced this pull request Dec 19, 2016

Closed

Allow to specify web proxy #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment