Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation component assumes handled props property on class is available #1329

Closed
eljefe223 opened this Issue Jan 22, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@eljefe223
Copy link
Contributor

eljefe223 commented Jan 22, 2019

Describe the bug; what happened?
We don't check if this.handledprops exists before we check hasOwnProperty causing a runTime error.

What are the steps to reproduce the issue?

Example:

  1. Create a foundation component
  2. Pass unhandled props without setting handledprops

What behavior did you expect?
We should check if this.handledprops exist before we check hasOwnProperty

If applicable, provide screenshots:

In what environment did you see the issue?

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Edge, Chrome, Safari, FireFox]
  • Version [e.g. 1.8.0]

Is there any additional context?

@jkmdev

This comment has been minimized.

Copy link
Contributor

jkmdev commented Feb 12, 2019

Hi @eljefe223, would it be okay with you if I worked on this one?

@eljefe223

This comment has been minimized.

Copy link
Contributor Author

eljefe223 commented Feb 12, 2019

@jkmdev please, go for it.

macarva added a commit to macarva/fast-dna that referenced this issue Mar 15, 2019

@macarva macarva referenced this issue Mar 15, 2019

Merged

fix: added test for bug #1329 and fixed the bug #1547

4 of 8 tasks complete

macarva added a commit to macarva/fast-dna that referenced this issue Mar 18, 2019

nicholasrice added a commit that referenced this issue Mar 18, 2019

fix: added test for bug #1329 and fixed the bug (#1547)
* added test for bug #1329 and fixed the bug

* Changes as per comment
@nicholasrice

This comment has been minimized.

Copy link
Member

nicholasrice commented Mar 30, 2019

closed by #1547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.