Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSemantic highlighting protocol extension #513
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rcjsuen
Jul 4, 2018
Contributor
@kittaakos Just to make sure I understand what's going on, would you mind showing the JSON notification of a) opening a new file and b) making a change to one line? Let's just say the URI of the file is lsp:/folder/file.ts.
A: User opens the following TypeScript file in a LSP client.
export class Sample {
protected test = 0;
}B: User changes 0 to "value" on the second line.
export class Sample {
protected test = "value";
}|
@kittaakos Just to make sure I understand what's going on, would you mind showing the JSON notification of a) opening a new file and b) making a change to one line? Let's just say the URI of the file is A: User opens the following TypeScript file in a LSP client. export class Sample {
protected test = 0;
}B: User changes export class Sample {
protected test = "value";
} |
kittaakos
referenced this issue
Jul 4, 2018
Open
Support the semantic highlighting based on the LSP extension proposal #715
dbaeumer
added
feature-request
discussion
labels
Jul 5, 2018
DJMcNab
referenced this issue
Aug 29, 2018
Open
Parameter Hints shown inline all the time (like IntelliJ) #16221
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nickmccurdy
Aug 30, 2018
Great idea, it's always bugged me that different editors have different syntax highlighting semantics.
nickmccurdy
commented
Aug 30, 2018
|
Great idea, it's always bugged me that different editors have different syntax highlighting semantics. |
kittaakos commentedJul 4, 2018
Note: The description was copied as is from Microsoft/vscode-languageserver-node#368 (comment)
I have started to work on a semantic highlighting extension of the LSP.
The semantic highlighting information is pushed from the server to the client as a notification. This notification contains the lines and the ranges where the coloring has the be applied and the desired coloring details are given as TextMate scopes.
In the reference implementation of the client, I was trying to map the TextMate scopes into the appropriate theme I can use as a decoration in the
TextEditordecoration. How can one map the TextMate scopes into themes (and eventuallyTextEditorDecorationType) with the current VS Code API?Any suggestions and feedback are welcome. Thanks!
Related issues:
Microsoft/language-server-protocol)Microsoft/language-server-protocol)Microsoft/vscode)Microsoft/language-server-protocol)The corresponding PR with the proposed changes is here: Microsoft/vscode-languageserver-node#367