DidChange might only have new text #198

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@ljw1004
Contributor

ljw1004 commented Mar 8, 2017

Currently the spec says that TextDocumentContentChangeEvent.text contains the new text of the document.

I assume that, if the server requested incremental changes and if the client obliged by sending a range+rangelength, then the text field merely contains the new text of the range.

DidChange might only have new text
Currently the spec says that `TextDocumentContentChangeEvent.text` contains the new text of the *document*.

I assume that, if the server requested incremental changes and if the client obliged by sending a range+rangelength, then the `text` field merely contains the new text of the *range*.
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Mar 8, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

msftclas commented Mar 8, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dbaeumer

This comment has been minimized.

Show comment
Hide comment
@dbaeumer

dbaeumer Mar 9, 2017

Member

Correct !

Member

dbaeumer commented Mar 9, 2017

Correct !

@dbaeumer dbaeumer merged commit 2f5f03b into Microsoft:master Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment