Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sticky sidebar going off page on Desktop #444

Merged
merged 1 commit into from Apr 18, 2018

Conversation

@caleblloyd
Copy link
Contributor

commented Apr 5, 2018

Presently the sticky sidebar is off the screen when expanded on desktop. It is not possible to scroll the sticky sidebar. I have a 1080p screen so this affects many users. Solution in this PR is to disable stickiness on the sidebar add scrolling to the sticky sidebar if needed.

screenshot-2018-4-5 specification

@caleblloyd caleblloyd force-pushed the caleblloyd:patch-1 branch from 3170b82 to 06eabfc Apr 5, 2018

@caleblloyd

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

The sticky sidebar is a nice feature when browsing long docs. I have updated the PR to add scrolling to the sticky sidebar when it is taller than the screen with overflow: auto

@caleblloyd caleblloyd force-pushed the caleblloyd:patch-1 branch from 06eabfc to ae7be29 Apr 5, 2018

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Apr 6, 2018

@auchenberg can you please have a look. You know more about this than I do.

@caleblloyd

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2018

@dbaeumer @auchenberg here is a rendered preview of the change. As you can see, not possible to scroll the sidebar currently and it goes off the page. After PR, it is possible to scroll the sidebar.

lsp-pr

@dbaeumer dbaeumer added this to the April 2018 milestone Apr 16, 2018

@auchenberg

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2018

LGTM!

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Apr 18, 2018

@auchenberg thanks. Merging it in then.

@dbaeumer dbaeumer merged commit 9b0c512 into microsoft:gh-pages Apr 18, 2018

1 check passed

license/cla All CLA requirements met.
@dbaeumer

This comment has been minimized.

Copy link
Member

commented Apr 18, 2018

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.