Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeActionOptions with providedCodeActionKinds #534

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@Gama11
Copy link
Contributor

commented Jul 28, 2018

See here for the motivation: #389 (comment)

Corresponding vscode-languageclient PR: microsoft/vscode-languageserver-node#385

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

Adding this makes complete sense to me.

@dbaeumer dbaeumer merged commit 20d0cec into microsoft:gh-pages Aug 21, 2018

1 check passed

license/cla All CLA requirements met.

@Gama11 Gama11 deleted the Gama11:codeActionOptions branch Aug 21, 2018

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

I renamed the property to codeActionKinds to make it consistent with the LSP naming. We never have provided in the capability name if the server provides something. The provide is already part of the top level naming (e.g. codeActionProvider)

@Gama11

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2018

Make sense! My original naming was consistent with the VSCode API, but consistency with the LSP indeed seems more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.