Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed FoldingRangeRequestParam => FoldingRangeParams #550

Merged
merged 1 commit into from Aug 29, 2018

Conversation

@spoenemann
Copy link
Contributor

commented Aug 22, 2018

For all other requests, the single parameter type is named ...Params. For consistency, this pattern should also apply to the new folding range request.

@spoenemann

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2018

By the way, the export keyword doesn't make any sense in the specification. Should it be stripped off?

@rcjsuen

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

Personally, I would prefer changing it to FoldingRangeParams and dropping Request from the name. Outside of ShowMessageRequestParams, all the other parameters do not include the word Request in its interface name.

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

+1 for removing request

Renamed FoldingRangeRequestParam => FoldingRangeParams
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>

@spoenemann spoenemann force-pushed the TypeFox:msp_foldingRangeParam branch from f082821 to 533a4b9 Aug 23, 2018

@spoenemann spoenemann changed the title Renamed FoldingRangeRequestParam => FoldingRangeRequestParams Renamed FoldingRangeRequestParam => FoldingRangeParams Aug 23, 2018

@spoenemann

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2018

Done.

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Aug 29, 2018

@aeschli can you please decide on this. We should do this sooner than later

@dbaeumer dbaeumer merged commit 24b229a into microsoft:gh-pages Aug 29, 2018

1 check passed

license/cla All CLA requirements met.

aeschli added a commit to microsoft/vscode-languageserver-node that referenced this pull request Aug 29, 2018

@spoenemann spoenemann deleted the TypeFox:msp_foldingRangeParam branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.