New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all options as optional in the type definitions #53

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Contributor

pimterry commented Nov 22, 2018

Currently, the options object is optional, but none of the properties. That means if you pass an options object, you must pass all options. This PR makes each individual option optional too, so you can pass only the ones you care about.

@alexandrudima

This comment has been minimized.

Member

alexandrudima commented Nov 23, 2018

👍 Thank you!

@alexandrudima alexandrudima merged commit 9941fe0 into Microsoft:master Nov 23, 2018

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment