Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find variable: Intl error on Safari #327

Closed
samelhusseini opened this issue Jan 19, 2017 · 7 comments
Closed

Can't find variable: Intl error on Safari #327

samelhusseini opened this issue Jan 19, 2017 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@samelhusseini
Copy link

monaco-editor npm version: 0.8.0
Browser: Safari
OS: Mac

screen shot 2017-01-19 at 11 23 30 am

Repro: Visit https://microsoft.github.io/monaco-editor/playground.html on Safari

@alexdima
Copy link
Member

alexdima commented Jan 21, 2017

Caused by microsoft/vscode#18539

@bpasero Can you please try running the editor in Safari, it appears Intl is not defined there.

@alexdima alexdima added this to the v0.8.x milestone Jan 21, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jan 21, 2017
@bpasero
Copy link
Member

bpasero commented Jan 21, 2017

@alexandrudima I pushed a workaround, note that Intl is defined since Safari 10 (from 2014), so at some point we have to decide what we want to support on macOS.

@bpasero bpasero closed this as completed Jan 21, 2017
@alexdima
Copy link
Member

@bpasero Many thanks.

@MicrosoftSam What Safari version do you have?

@samelhusseini
Copy link
Author

Safari Version 9.0.3

@samelhusseini
Copy link
Author

samelhusseini commented Jan 25, 2017

Repro's on 9.1.2 as well. Looks like this has been fixed in the vscode repo. @alexandrudima is there going to be a monaco-editor 8.1 that will include this fix?

@alexdima
Copy link
Member

@MicrosoftSam Yes, we are now in endgame and just did a test pass to uncover more bugs. 0.8.1 will come out, hopefully we can wrap it up at the end of this week.

@sandyarmstrong
Copy link
Member

@bpasero @alexandrudima fwiw, this bug exists when using monaco-editor 0.8.0 in a webkit webview even on macOS 10.11 with Safari 10 installed. Hopefully monaco-editor will continue to support Safari 9 for the embedded scenario.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

4 participants