New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repoint SDK40ToolsPath to 4.7.2 registry location #4049

Closed
rainersigwald opened this Issue Jan 7, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@rainersigwald
Copy link
Contributor

rainersigwald commented Jan 7, 2019

This was reported internally as https://devdiv.visualstudio.com/DevDiv/_workitems/edit/753670.

On a machine with VS installed but no .NET 4.6.1 SDK, $(SDK40ToolsPath) is empty, because

<property name="SDK40ToolsPath" value="$([MSBuild]::GetRegistryValueFromView('HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft SDKs\NETFXSDK\4.6.1\WinSDK-NetFx40Tools-x86', 'InstallationFolder', null, RegistryView.Registry32))" />

doesn't exist.

I think the 4.6.1 SDK was universally installed for dev15, but dev16 now universally installs the 4.7.2 SDK, so we should update to point to that instead.

@steffen-wilke

This comment has been minimized.

Copy link

steffen-wilke commented Jan 8, 2019

I was about to open similar issue when I found this, good timing on your side :)

A related issue that I've fought with this morning was to get the creation of localized satellite assemblies running on our Docker Based Build Servers. I'm using the microsoft/dotnet-framework:4.7.2-sdk-20181211-windowsservercore-ltsc2016 Docker image as a base for our build containers.

And our build process resulted in the outcome:

> You should have .NET 4.7.2 SDK installed.
> Can't create the satellite assembly dll.
> .NET 4.7.2 framework tools not found. Make sure that .NET framework has been installed.
> "AL.exe" file does not exist.

Installing Microsoft.VisualStudio.Workload.ManagedDesktopBuildTools from the vs_buildtools to the image fixed the issue for me. This seems to be the Component that also installs the .NET 4.6.1 SDK to the machine.

Edit: Installing only Microsoft.Net.Component.4.6.1.SDK also worked

While only building .NET 4.7.2 projects, out build servers also have to have .NET 4.6.1 SDK installed at the moment which is a bit inconvenient.

Another example of this problem is the usage of the resgen.exe while building our solutions which is being accessed from the path C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\resgen.exe.

Maybe the Microsoft .NET 4.7.2 SDK Docker Images should be extended with the required .NET 4.6.1 SDK by default.

@rainersigwald

This comment has been minimized.

Copy link
Contributor

rainersigwald commented Jan 8, 2019

Maybe the Microsoft .NET 4.7.2 SDK Docker Images should be extended with the required .NET 4.6.1 SDK by default.

That sounds reasonable to me. I filed Microsoft/dotnet-framework-docker#214 to see if it seems reasonable to the Dockerfile owners.

Thanks for the report and additional details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment