New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from MSTest to xunit #6

Closed
akoeplinger opened this Issue Mar 18, 2015 · 13 comments

Comments

Projects
None yet
7 participants
@akoeplinger
Member

akoeplinger commented Mar 18, 2015

MSTest isn't available cross-platform and the other dotnet open source projects like corefx migrated to xunit already.

@AndyGerlicher

This comment has been minimized.

Show comment
Hide comment
@AndyGerlicher

AndyGerlicher Mar 18, 2015

Member

Our cross platform branch already has them in nunit so they work on other platforms. Xunit is probably a better choice though since corefx/coreclr is using that.

Either way that branch should be posted within a week or so.

Member

AndyGerlicher commented Mar 18, 2015

Our cross platform branch already has them in nunit so they work on other platforms. Xunit is probably a better choice though since corefx/coreclr is using that.

Either way that branch should be posted within a week or so.

@akoeplinger

This comment has been minimized.

Show comment
Hide comment
@akoeplinger

akoeplinger Mar 18, 2015

Member

Great! Yeah I think it'd be good to use the same testing frameworks as the .NET Core repos.

Member

akoeplinger commented Mar 18, 2015

Great! Yeah I think it'd be good to use the same testing frameworks as the .NET Core repos.

@mmitche

This comment has been minimized.

Show comment
Hide comment
@mmitche

mmitche Mar 18, 2015

Member

+1 to using the same harness please.

Member

mmitche commented Mar 18, 2015

+1 to using the same harness please.

@olivierrr

This comment has been minimized.

Show comment
Hide comment
@olivierrr

olivierrr commented Mar 19, 2015

👍

@NotMyself

This comment has been minimized.

Show comment
Hide comment
@NotMyself

NotMyself commented Mar 19, 2015

:shipit:

@Maxwe11

This comment has been minimized.

Show comment
Hide comment
@Maxwe11

Maxwe11 Mar 29, 2015

Which xunit should be installed (from nuget.org or dotnetbuild-tools on myget.org) ?
What else should be done except changes in code?

Maxwe11 commented Mar 29, 2015

Which xunit should be installed (from nuget.org or dotnetbuild-tools on myget.org) ?
What else should be done except changes in code?

@mmitche

This comment has been minimized.

Show comment
Hide comment
@mmitche

mmitche Mar 30, 2015

Member

@Maxwe11 You should use the one on dotnet-buildtools, which is being updated as necessary to work well with CoreCLR

Member

mmitche commented Mar 30, 2015

@Maxwe11 You should use the one on dotnet-buildtools, which is being updated as necessary to work well with CoreCLR

@mmitche

This comment has been minimized.

Show comment
Hide comment
@mmitche

mmitche Apr 8, 2015

Member

Add to this that the tests should be runnable from the command line.

@AndyGerlicher We probably need to make the tests runnable from the command line (or directly from the build) to make them useful in CI. Can we move msbuild to xunit (also has VS integration) and integrate the tests into the command line build (like corefx) asap? Can that change be merged into master?

Member

mmitche commented Apr 8, 2015

Add to this that the tests should be runnable from the command line.

@AndyGerlicher We probably need to make the tests runnable from the command line (or directly from the build) to make them useful in CI. Can we move msbuild to xunit (also has VS integration) and integrate the tests into the command line build (like corefx) asap? Can that change be merged into master?

@AndyGerlicher

This comment has been minimized.

Show comment
Hide comment
@AndyGerlicher

AndyGerlicher Apr 8, 2015

Member

Yes @mmitche that is definitely a change we would want to take (and merged into master). Just not the highest priority right now (focusing on getting corefx to build on Linux/Mac).

Member

AndyGerlicher commented Apr 8, 2015

Yes @mmitche that is definitely a change we would want to take (and merged into master). Just not the highest priority right now (focusing on getting corefx to build on Linux/Mac).

@AndyGerlicher

This comment has been minimized.

Show comment
Hide comment
@AndyGerlicher

AndyGerlicher Aug 17, 2015

Member

Ideally this should be done in master.

Member

AndyGerlicher commented Aug 17, 2015

Ideally this should be done in master.

@rainersigwald

This comment has been minimized.

Show comment
Hide comment
@rainersigwald

rainersigwald Aug 27, 2015

Contributor

Because of xunit/xunit#560, it looks like the initial implementation of this will drop VS support and have only command line/MSBuild test execution.

Contributor

rainersigwald commented Aug 27, 2015

Because of xunit/xunit#560, it looks like the initial implementation of this will drop VS support and have only command line/MSBuild test execution.

rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Sep 2, 2015

XUnitConverter for Framework unit tests
This is a stepping stone toward Microsoft#6.  I haven't sent PRs for all of my
changes to the tool, so if you want to replicate this you'll need to use
https://github.com/rainersigwald/codeformatter at commit
9908fb8bb04434543828f1fadcd5b3f0663194a0.

I ran:

XUnitConverter.exe src\Framework\UnitTests\Microsoft.Build.Framework.UnitTests.csproj

Followed by:

CodeFormatter.exe src\MSBuild.sln

rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Sep 2, 2015

XUnitConverter for Framework unit tests
This is a stepping stone toward Microsoft#6.  I haven't sent PRs for all of my
changes to the tool, so if you want to replicate this you'll need to use
https://github.com/rainersigwald/codeformatter at commit
9908fb8bb04434543828f1fadcd5b3f0663194a0.

I ran:

XUnitConverter.exe src\Framework\UnitTests\Microsoft.Build.Framework.UnitTests.csproj

Followed by:

CodeFormatter.exe src\MSBuild.sln

rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Sep 2, 2015

XUnitConverter for Framework unit tests
This is a stepping stone toward Microsoft#6.  I haven't sent PRs for all of my
changes to the tool, so if you want to replicate this you'll need to use
https://github.com/rainersigwald/codeformatter at commit
9908fb8bb04434543828f1fadcd5b3f0663194a0.

I ran:

XUnitConverter.exe src\Framework\UnitTests\Microsoft.Build.Framework.UnitTests.csproj

Followed by:

CodeFormatter.exe src\MSBuild.sln

@AndyGerlicher AndyGerlicher modified the milestones: Sprint 89, Sprint 88 Sep 3, 2015

@AndyGerlicher

This comment has been minimized.

Show comment
Hide comment
@AndyGerlicher

AndyGerlicher Sep 3, 2015

Member

Moving to Sprint 89.

Member

AndyGerlicher commented Sep 3, 2015

Moving to Sprint 89.

@rainersigwald

This comment has been minimized.

Show comment
Hide comment
@rainersigwald

rainersigwald Sep 16, 2015

Contributor

Done with #201. Some follow-up work: #210, #211.

Contributor

rainersigwald commented Sep 16, 2015

Done with #201. Some follow-up work: #210, #211.

AndyGerlicher pushed a commit to AndyGerlicher/msbuild that referenced this issue Feb 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment