New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tnir fix #240

Merged
merged 6 commits into from Apr 25, 2017

Conversation

Projects
None yet
4 participants
@xiangyushawn
Contributor

xiangyushawn commented Apr 6, 2017

connected to #206

Rework on TNIR

  1. Turn TNIR off for Fed Auth
  2. Change the TNIR multiplier to 0.125 instead of 0.08
  3. Change the time slices to a multiple of 2,4,8 instead of 2,3,4
  4. In case the timeout for the first slice is less than 500 ms then bump it up to 500 ms
  5. Keep TNIR on if the user has explicitly specified it in the connection string.
@codecov-io

This comment has been minimized.

codecov-io commented Apr 6, 2017

Codecov Report

Merging #240 into dev will increase coverage by 0.03%.
The diff coverage is 47.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #240      +/-   ##
============================================
+ Coverage     33.48%   33.51%   +0.03%     
- Complexity     1487     1493       +6     
============================================
  Files            97       97              
  Lines         23390    23404      +14     
  Branches       3840     3846       +6     
============================================
+ Hits           7831     7843      +12     
+ Misses        13998    13995       -3     
- Partials       1561     1566       +5
Flag Coverage Δ Complexity Δ
#JDBC41 33.43% <47.05%> (+0.03%) 1487 <0> (+6) ⬆️
#JDBC42 33.37% <47.05%> (-0.02%) 1485 <0> (+3)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 41.23% <47.05%> (+0.13%) 229 <0> (+2) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.91% <0%> (-0.18%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.05% <0%> (-0.15%) 183% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 24.42% <0%> (+0.41%) 174% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df06f67...a262878. Read the comment docs.

@xiangyushawn xiangyushawn referenced this pull request Apr 6, 2017

Closed

Tnir changes #209

@xiangyushawn xiangyushawn requested a review from saurabh500 Apr 6, 2017

@saurabh500

This comment has been minimized.

Member

saurabh500 commented Apr 6, 2017

LGTM

@xiangyushawn

This comment has been minimized.

Contributor

xiangyushawn commented Apr 6, 2017

@saurabh500 Thank you for your review. I will merge it soon.

@v-nisidh

This comment has been minimized.

Contributor

v-nisidh commented Apr 10, 2017

connected to #206

@xiangyushawn xiangyushawn merged commit cf732fe into Microsoft:dev Apr 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xiangyushawn xiangyushawn deleted the xiangyushawn:TNIR-Fix branch Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment