New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove JNI method for ActiveDirectoryPassword Authentication #256

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Projects
None yet
6 participants
@xiangyushawn
Contributor

xiangyushawn commented Apr 18, 2017

remove JNI method for ActiveDirectoryPassword Authentication, since we no longer use DLL for ActiveDirectoryPassword authentication

remove JNI method for ActiveDirectoryPassword Authentication, since w…
…e no longer use DLL for ActiveDirectoryPassword authentication
@codecov-io

This comment has been minimized.

codecov-io commented Apr 18, 2017

Codecov Report

Merging #256 into dev will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #256      +/-   ##
============================================
+ Coverage     33.77%   33.82%   +0.04%     
- Complexity     1522     1523       +1     
============================================
  Files           101      101              
  Lines         23600    23598       -2     
  Branches       3876     3876              
============================================
+ Hits           7972     7982      +10     
+ Misses        14061    14042      -19     
- Partials       1567     1574       +7
Flag Coverage Δ Complexity Δ
#JDBC41 33.66% <ø> (+0.01%) 1510 <ø> (-1) ⬇️
#JDBC42 33.76% <ø> (+0.16%) 1519 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/AuthenticationJNI.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-1.13%) 16% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 27.45% <0%> (-0.67%) 49% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 69.69% <0%> (-0.17%) 4% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.05% <0%> (+0.07%) 184% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 25.17% <0%> (+0.08%) 179% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 38.29% <0%> (+0.34%) 0% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 39.05% <0%> (+1.18%) 27% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f88c5...a556d82. Read the comment docs.

@xiangyushawn xiangyushawn requested a review from Ahmad-Ibra Apr 20, 2017

@Ahmad-Ibra Ahmad-Ibra merged commit eb801aa into Microsoft:dev Apr 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ajlam ajlam removed the PR Under Review label Apr 26, 2017

@xiangyushawn xiangyushawn deleted the xiangyushawn:clean-AAD-Authentication-methods branch Apr 26, 2017

@v-nisidh v-nisidh added this to the 6.1.7 milestone Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment