New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAD integration auth using DLL and ADAL4J #603

Merged
merged 15 commits into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@AfsanehR
Member

AfsanehR commented Jan 13, 2018

If operating system is Windows, use DLL to authenticate with integrated authentication mode, otherwise use ADAL4j dependency.

If DLL is not loaded or operating system is not windows use ADAL4J.

Note: This PR fails for now because it requires ADAL4J 1.4.0 release

@cheenamalhotra cheenamalhotra added this to the 6.4.0 milestone Jan 18, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Jan 18, 2018

Codecov Report

Merging #603 into dev will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #603      +/-   ##
============================================
+ Coverage     46.44%   46.52%   +0.07%     
+ Complexity     2219     2215       -4     
============================================
  Files           108      108              
  Lines         25340    25363      +23     
  Branches       4178     4179       +1     
============================================
+ Hits          11770    11799      +29     
+ Misses        11546    11538       -8     
- Partials       2024     2026       +2
Flag Coverage Δ Complexity Δ
#JDBC41 46.35% <0%> (+0.06%) 2208 <0> (-2) ⬇️
#JDBC42 46.34% <0%> (+0.04%) 2209 <0> (-1) ⬇️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/AuthenticationJNI.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.77% <0%> (+0.03%) 276 <0> (ø) ⬇️
...microsoft/sqlserver/jdbc/SQLServerADAL4JUtils.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-2.25%) 16% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.39% <0%> (-0.44%) 44% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.62% <0%> (-0.17%) 4% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.86% <0%> (-0.09%) 241% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.51% <0%> (ø) 238% <0%> (-1%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd1a72...b567e72. Read the comment docs.

@AfsanehR AfsanehR merged commit 2e5d9d3 into Microsoft:dev Jan 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment