New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of logic for checking the condition for using Bulk Copy API #736

Merged
merged 1 commit into from Jul 4, 2018

Conversation

5 participants
@peterbae
Member

peterbae commented Jul 3, 2018

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 3, 2018

Codecov Report

Merging #736 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #736      +/-   ##
============================================
- Coverage     48.52%   48.49%   -0.04%     
  Complexity     2747     2747              
============================================
  Files           115      115              
  Lines         27156    27156              
  Branches       4547     4547              
============================================
- Hits          13177    13168       -9     
- Misses        11809    11827      +18     
+ Partials       2170     2161       -9
Flag Coverage Δ Complexity Δ
#JDBC42 48% <0%> (ø) 2707 <0> (+3) ⬆️
#JDBC43 48.38% <0%> (+0.08%) 2740 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 54.61% <0%> (ø) 211 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75% <0%> (-1.57%) 30% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.74% <0%> (-0.68%) 106% <0%> (-2%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.88% <0%> (-0.45%) 87% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.12% <0%> (-0.24%) 0% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.51% <0%> (-0.19%) 332% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.77% <0%> (-0.14%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 53.41% <0%> (-0.13%) 262% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (ø) 16% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.21% <0%> (+0.51%) 251% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f95c9...64b87d5. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Jul 4, 2018

@ulvii

ulvii approved these changes Jul 4, 2018

@rene-ye

rene-ye approved these changes Jul 4, 2018

@peterbae peterbae merged commit 7fa7fa6 into Microsoft:dev Jul 4, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Jul 4, 2018

@cheenamalhotra cheenamalhotra added this to the 7.0.0 milestone Jul 4, 2018

cheenamalhotra added a commit that referenced this pull request Jul 31, 2018

Update master post RTW 7.0 release (#766)
* Update Snapshot for upcoming RTW release v7.0.0

* Change order of logic for checking the condition for using Bulk Copy API (#736)

Fix | Change order of logic for checking the condition for using Bulk Copy API (#736)

* Update CHANGELOG.md

* Merge pull request #732 from cheenamalhotra/module (Export driver in automatic module)

Introduce Automatic Module Name in POM.

* Update CHANGELOG.md

* Change Sha1HashKey to CityHash128Key for generating PreparedStatement handle and metadata cache keys (#717)

* Change Sha1HashKey to CityHash128Key

* Formatted code

* Prepared statement performance fixes

1) Further speedups to prepared statement hashing

2) Caching of '?' chararacter positiobs in prepared statements to speed parameter substitution

* String compare for hash keys
added missing line for bulkcopy tests.

* comment change

* Move CityHash class to a separate file

* spacings fixes
cleaner code & logic

* Add | Adding useBulkCopyForBatchInsert property to Request Boundary methods (#739)

* Apply the collation name change to UTF8SupportTest

* Package changes for CityHash with license information (#740)

* Reformatted Code + Updated formatter (#742)

* Reformatted Code + Updated formatter

* Fix policheck issue with 'Country' keyword (#745)

* Adding a new test for beginRequest()/endRequest() (#746)

* Add | Adding a new test to notify the developers to consider beginRequest()/endRequest() when adding a new Connection API

* Fix | Fixes for issues reported by static analysis tools (SonarQube + Fortify) (#747)

* handle buffer reading

for invalid buffer input by user

* Revert "handle buffer reading"

This reverts commit 11e2bf4.

* updated javadocs (#754)

* fixed some typos in javadocs (#760)

* API and JavaDoc changes for Spatial Datatypes (#752)

Add | API and JavaDoc changes for Spatial Datatypes (#752)

* Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

fix | Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

* Formatting | Change scope of unwanted Public APIs + Code Format (#757)

* Fix unwanted Public APIs.
* Updated formatter to add new line to EOF + formatted project

* Release | Release 7.0 changelog and version update (#748)

* Updated Changelog + release version changes

* Changelog entry updated as per review.

* Updated changelog for new changes

* Terminology update: request boundary declaration APIs

* Trigger Appveyor

* Update Samples and add new samples for new features (#761)

* Update Samples and add new Samples for new features

* Update samples from Peter

* Updated JavaDocs

* Switch to block comment

* Update License copyright (#767)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment