Move to TypeScript 2.6.1 #3559

riknoll · 2017-12-04T19:47:13Z

This moves us from TypeScript 1.8.7 to Typescript 2.6.1 (both for our compiler and our code). Benefits include:

No more typings; everything is now in @types and it should be much easier to add new types because we no longer need to get pre-2.0 compatible definitions
Async await
String enums
Lots of other stuff https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-6.html

This is a very dangerous change and should not be merged before any big releases. It is also a breaking change. For example, this code is no longer legal:

if (2 === 3) {
 // do something
}

TypeScript 2.0+ considers that comparison to be between the types 2 and 3 and not two numbers, so this comes up as an error. I'm sure there is other stuff I'm not thinking of.

Things still to be done:

Not sure how much needs to be done with the Monaco language service
Update our React version (we were waiting on the new types)
Use Async await all over the place

Testing

basic test run against Adafruit
basic test run against Minecraft
basic test run against Chibitronics

pelikhan · 2017-12-05T23:19:16Z

package.json

@@ -108,8 +108,19 @@
    "semantic-ui-less": "^2.2.11",


dump the minor version as well

pelikhan · 2017-12-05T23:23:14Z

pxtcompiler/emitter/decompiler.ts

@@ -302,7 +302,7 @@ namespace ts.pxtc.decompiler {

    export function decompileToBlocks(blocksInfo: pxtc.BlocksInfo, file: ts.SourceFile, options: DecompileBlocksOptions, renameMap?: RenameMap): pxtc.CompileResult {
        let emittedBlocks = 0;
-        let stmts: ts.Statement[] = file.statements;
+        let stmts: NodeArray<ts.Statement> = file.statements;


is this a new type?

No, but the type definition in the TS compiler changed so it can no longer be assigned to a normal array. Pretty sure the reason is that the indices are readonly in the NodeArray (which is a TS 2.0 feature).

pelikhan · 2017-12-05T23:26:46Z

pxtcompiler/emitter/service.ts

@@ -566,7 +564,7 @@ namespace ts.pxtc.service {
        }
    }

-    const operations: pxt.Map<(v: OpArg) => any> = {
+    const operations: pxt.Map<(v: any) => any> = {


pelikhan · 2017-12-05T23:29:22Z

pxtlib/docsrender.ts

@@ -249,12 +248,12 @@ namespace pxt.docs {

        if (currentTocEntry) {
            if (currentTocEntry.prevPath) {
-                params["prev"] = `<a href="${currentTocEntry.prevPath}" class="navigation navigation-prev " title="${'Previous page: {0}', currentTocEntry.prevName}">
+                params["prev"] = `<a href="${currentTocEntry.prevPath}" class="navigation navigation-prev " title="${currentTocEntry.prevName}">


why this change?

Look at the comma; the left side isn't doing anything so the TS compiler was throwing an error. I'm not sure what the desired behavior is, but my change shouldn't affect the current behavior.

Oh... it is missing lf("..."). Let's keep this change. simpler.

pelikhan · 2017-12-05T23:32:11Z

pxtsim/libgeneric.ts

@@ -513,16 +513,6 @@ namespace pxsim {
            return new RefBuffer(buf.data.slice(offset, offset + length));
        }

-        export function toHex(buf: RefBuffer): string {


Not used anywhere

Oh, it's a sim-shim. I'll bring it back

pelikhan

LGTM

pelikhan · 2017-12-05T23:33:25Z

pxtsim/svg.ts

@@ -73,15 +73,15 @@ namespace pxsim.svg {


    export function fill(el: SVGElement, c: string) {
-        (<SVGStylable><any>el).style.fill = c;


No more SVGStyleable?

Yeah, I couldn't find it in lib.d.ts. Either it's gone or the name changed.

pelikhan · 2017-12-05T23:39:06Z

pxtcompiler/emitter/emitter.ts

@@ -309,7 +325,7 @@ namespace ts.pxtc {
        while (true) {
            node = node.parent
            if (!node)
-                userError(9229, lf("cannot determine parent of {0}", stringKind(node0)))
+            userError(9229, lf("cannot determine parent of {0}", stringKind(node0)))


missing tab?

pelikhan · 2017-12-05T23:40:16Z

pxtcompiler/emitter/emitter.ts

@@ -557,6 +599,39 @@ namespace ts.pxtc {
        return checkType(r)
    }

+    function checkUnionOfLiterals(t: Type): HasLiteralType {


coool! do we have tests on those?

pelikhan · 2017-12-05T23:42:16Z

pxtcompiler/emitter/emitter.ts

+                msg = lf("{0} not supported", ts.SyntaxKind[n.kind])
+            }
+
+            let t = (n as any) as any[];


left over logging

pelikhan · 2017-12-05T23:43:24Z

pxtcompiler/emitter/emitter.ts

@@ -3310,13 +3404,13 @@ ${lbl}: .short 0xffff
                return r;
            let tp = typeOf(e)

-            if (target.floatingPoint && (tp.flags & (TypeFlags.NumberLike | TypeFlags.Boolean)))
+            if (target.floatingPoint && (tp.flags & (TypeFlags.NumberLike | TypeFlags.Boolean | TypeFlags.BooleanLiteral)))


at this point, we should really clean out the floating point stuff

Maybe it needs a general cleanup but I'm convinced we should leave support for integer compilation for tiny targets (AVR, maybe some tiny ARMS)

mmoskal

Wow! That's a lot of changes - reminds me updates to TD back when TS was changing even faster ;))

Looks great!

mmoskal · 2017-12-05T23:45:44Z

cli/cli.ts

@@ -2300,14 +2302,14 @@ class Host
        check(p)

        if (U.endsWith(filename, ".uf2"))
-            fs.writeFileSync(p, contents, "base64")
+            fs.writeFileSync(p, contents, { encoding: "base64" })


Node.js doesn't seem to deprecate string as encoding usage. Is the @types missing it?

Yeah, you're right. Not sure why it was removed from the @types

lock · 2019-09-26T14:06:34Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

riknoll added 18 commits November 7, 2017 16:09

getting it to build

844c001

More changes for new TS

9626df7

More compiler and decompiler fixes

d664084

Fixing error tests and decompiler baseline

a4163bd

Fix path in cli

addea33

Merge remote-tracking branch 'origin/master' into new_ts

c9ebe30

node and jquery @types

2ba7de9

React @types

f55927e

More @types work

35c701b

More @types

22451b3

Lock down types versions

bd8445d

Merge remote-tracking branch 'origin/master' into new_ts

9db26ed

Lint errors

0dad9bb

Fix test tsconfigsz

e6c98f4

Removing log statement

38c3f84

Minor bugs

58c2ebd

Merge remote-tracking branch 'origin/master' into new_ts

516ca70

Uncommenting tests

973a1e7

riknoll added the DO NOT MERGE label Dec 4, 2017

riknoll requested review from pelikhan, abchatra, mmoskal, tballmsft, guillaumejenkins, cait1inhennessy and samelhusseini December 4, 2017 19:47

riknoll added 4 commits December 4, 2017 13:01

Fix type error

0203b37

Fix type checking error

8c30967

Fixing mistake when negating expression

fde1fc4

Fix generic operators on enums

0404948

pelikhan reviewed Dec 5, 2017

View reviewed changes

package.json

@@ -108,8 +108,19 @@

"semantic-ui-less": "^2.2.11",

Copy link

Member

pelikhan Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dump the minor version as well

pelikhan reviewed Dec 5, 2017

View reviewed changes

riknoll mentioned this pull request Dec 5, 2017

New ts changes microsoft/pxt-adafruit#555

Merged

pelikhan reviewed Dec 5, 2017

View reviewed changes

riknoll mentioned this pull request Dec 5, 2017

Changes for TS 2.6.1 microsoft/pxt-common-packages#191

Merged

pelikhan reviewed Dec 5, 2017

View reviewed changes

pelikhan approved these changes Dec 5, 2017

View reviewed changes

mmoskal reviewed Dec 5, 2017

View reviewed changes

riknoll added 2 commits December 5, 2017 16:09

PR Feedback

eaca55f

Merge remote-tracking branch 'origin/master' into new_ts

cf43c01

riknoll merged commit 749c2c4 into master Dec 11, 2017

riknoll deleted the new_ts branch February 17, 2018 01:25

lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to TypeScript 2.6.1 #3559

Move to TypeScript 2.6.1 #3559

riknoll commented Dec 4, 2017 •

edited by pelikhan

pelikhan Dec 5, 2017

pelikhan Dec 5, 2017

riknoll Dec 5, 2017

pelikhan Dec 5, 2017

pelikhan Dec 5, 2017

riknoll Dec 5, 2017

pelikhan Dec 5, 2017

pelikhan Dec 5, 2017

riknoll Dec 5, 2017

riknoll Dec 5, 2017

pelikhan left a comment

pelikhan Dec 5, 2017

riknoll Dec 5, 2017

pelikhan Dec 5, 2017

pelikhan Dec 5, 2017

pelikhan Dec 5, 2017

pelikhan Dec 5, 2017

pelikhan Dec 5, 2017

mmoskal Dec 5, 2017

mmoskal left a comment

mmoskal Dec 5, 2017

riknoll Dec 5, 2017

lock bot commented Sep 26, 2019

		@@ -73,15 +73,15 @@ namespace pxsim.svg {


		export function fill(el: SVGElement, c: string) {
		(<SVGStylable><any>el).style.fill = c;

Move to TypeScript 2.6.1 #3559

Move to TypeScript 2.6.1 #3559

Conversation

riknoll commented Dec 4, 2017 • edited by pelikhan

Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pelikhan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmoskal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lock bot commented Sep 26, 2019

riknoll commented Dec 4, 2017 •

edited by pelikhan