New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend rev-version to also update task.json build patch numbers #262

Open
jessehouwing opened this Issue Mar 16, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@jessehouwing

jessehouwing commented Mar 16, 2018

Right now --rev-version will patch the extension version, but leaves Build task versions alone. It would be lovely if --rev-version would also rev the build task versions.

@trevorsg

This comment has been minimized.

Member

trevorsg commented Mar 20, 2018

I wonder if there is an elegant way to do this. Right now TFX doesn't know about build tasks. Maybe add an optional parameter to --rev-version which specifies a file and a JSON path to the version to get revved?

Something like... tfx extension create --rev-version tasks.json:version somethingelse.json:settings.version

Essentially that would rev the version specified in the manifest, as well as tasks.json's "version" property and somethingelse.json's "settings.version" property.

@jessehouwing

This comment has been minimized.

jessehouwing commented Mar 20, 2018

@calebcartwright

This comment has been minimized.

calebcartwright commented Apr 3, 2018

FWIW - I'd love to have this capability too. On a somewhat related note..

We always ended up having to write custom code in each task repo since tfx didn't have task bumping capabilities and we couldn't find any existing modules that easily supported bumping the task version object out of the box.

We decided to write a custom gulp plugin to provide support for bumping our VSTS tasks, in case that's useful for anyone that wants to bump their VSTS tasks as part of their gulp workflows.

@calebcartwright

This comment has been minimized.

calebcartwright commented Jul 10, 2018

And we've now also published a CLI/Lib - https://www.npmjs.com/package/vsts-bump that can be used for bumping the patch, minor, or major version of VSTS tasks. Not sure if could be utilized by tfx, but we're running the bump cli and then tfx i.e. vsts-bump tasks/**/task.json && tfx [command] which has been working pretty well for us.

@jessehouwing

This comment has been minimized.

jessehouwing commented Aug 14, 2018

Ci/cd tasks for vsts extensions provides support for this as well. I've recently added multi-version task support on top of syncing version numbers.

@calebcartwright

This comment has been minimized.

calebcartwright commented Aug 14, 2018

Nice @jessehouwing! I use the CI/CD tools extension for my own extensions and it works wonderfully.

There were 2 scenarios/use cases where I wished tfx could bump task versions too though (and why we ultimately developed the aforementioned libs):

  • The "inner" development loop process: I typically upload all of my custom tasks directly to VSTS as I'm developing to test/validate (even if I ultimately publish them as an extension on the marketplace)
  • Private Tasks: at work we have a variety of custom tasks that we don't package as an extension and publish the marketplace, we just use tfx to upload the new versions to our accounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment