New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend tfx extension publish to allow overriding baseUri #263

Open
jessehouwing opened this Issue Mar 16, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@jessehouwing

jessehouwing commented Mar 16, 2018

Many people, including the ALM Rangers, use the CI/CD tasks for Extensions to manage their extension workflow. Part of that includes changing the base-uri of the extension to point to a dev, test or prod environment.

A common request I receive from extension developers is to be able to change the baseuri when publishing from vsix.

The proposed syntax would be similar to --publisher:

tfx extension publish --vsix .\ext.vsix --base-uri https://localhost/debug

An even better solution would be to allow --override or --override-json to work with --vsix.

@trevorsg

This comment has been minimized.

Member

trevorsg commented Mar 20, 2018

This is tricky because we have to crack open the vsix and make the necessary changes. Supporting only --base-uri is practically the same amount of work to support --override or similar options.

Furthermore, even if we do crack the vsix, there isn't an elegant way to know how to edit the files inside. TFX always generates an extension.vsixmanifest, and in the case of vsts/tfs extensions, also an extension.vsomanifest. TFX only knows how to create these files based on the target from the original manifest.

I'm thinking the best way to implement this is to include the original manifest in the vsix. It shouldn't add much to the package size since it will compress well - most of the data is included in other files. I'm thinking maybe we could add a restriction to --override when running against an existing package that says you cannot use it to change the files that are included in the package.

At this point, we know how to re-generate the manifest files and then it's just a matter of replacing them in the vsix.

@jessehouwing

This comment has been minimized.

jessehouwing commented Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment