Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port request: Abseil (Google's common library) #1883

Closed
arthur-tacca opened this issue Sep 27, 2017 · 13 comments
Closed

Port request: Abseil (Google's common library) #1883

arthur-tacca opened this issue Sep 27, 2017 · 13 comments
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!

Comments

@arthur-tacca
Copy link

Google has just released a library with some of their low-level code such as time, string handling, and their mutex class. There are plans to add logging and command-line flag infrastructure.

This is a pre-emptive request, because the library has just been released so it is not a dependency of any public project (or probably of any private project). But the announcement mentions that this library already existed privately inside Google, and bits of it are currently copy-and-pasted into protobuf and gRPC (already in vcpkg) and TensorFlow (#466), and this will change to a proper dependency over time. So sooner or later it will need to be included if these other packages are (still) to be.

@KindDragon
Copy link
Contributor

Bazel doesn't work for me on Windows

@KindDragon
Copy link
Contributor

KindDragon commented Sep 27, 2017

But the announcement mentions that this library already existed privately inside Google, and bits of it are currently copy-and-pasted into protobuf and gRPC (already in vcpkg) and TensorFlow (#466), and this will change to a proper dependency over time.

They will add for them CMake to Abseil

@arthur-tacca
Copy link
Author

I wasn't sure what that comment meant at first, but I think you're saying that Google is going to have to add CMake support to Abseil so that it can be used by these other projects. The implication being that there's no point vcpkg adding it now when official support will come anyway before it's really needed here. If that is what you meant, I agree.

@KindDragon
Copy link
Contributor

KindDragon commented Sep 27, 2017

If that is what you meant, I agree.

👍

@ras0219-msft ras0219-msft added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 28, 2017
@ras0219-msft
Copy link
Contributor

Totally experimental; don't take a dependency; etc etc:

I've written a replacement buildsystem for abseil in CMake available in master (9f9b4bc). It also installs targets (subject to change in the future according to what Google does for their official cmake buildsystem):

  find_package(unofficial-abseil REQUIRED)
  link_libraries(unofficial::abseil::strings unofficial::abseil::base)

@atkawa7
Copy link
Contributor

atkawa7 commented Sep 28, 2017

@ras0219-msft out of topic Are you guys at cppcon?

@ras0219-msft
Copy link
Contributor

Yep, I gave a talk on vcpkg on Tuesday and I'll be at the Microsoft booth all week if anyone wants to drop by!

@atkawa7
Copy link
Contributor

atkawa7 commented Sep 28, 2017

@ras0219-msft I am not. But would love to hear about the talks. Hopeful they are going to release some videos soon

@KindDragon
Copy link
Contributor

abseil/abseil-cpp#8

@gennadiycivil
Copy link

gennadiycivil commented Oct 4, 2017

Bazel is a build system for Abseil.
If anyone experiences Bazel problems on a supported platform (windows should work by the way ) please open issues and we shall see what we can do to address.
NOTE: Abseil team will still primarily support bazel, but we'll do our best to keep CMake working too once CMake support lands.

@KindDragon
Copy link
Contributor

I can't even run bazel on Windows bazelbuild/bazel#3821

@atkawa7
Copy link
Contributor

atkawa7 commented Oct 4, 2017

@KindDragon Bazel fails on windows most of the time. I don't think it is as stable as they assume it to be

@atkawa7
Copy link
Contributor

atkawa7 commented Jan 26, 2018

@ras0219-msft Please close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

No branches or pull requests

5 participants