Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evpp port file #1177

Merged
merged 1 commit into from May 31, 2017
Merged

Add evpp port file #1177

merged 1 commit into from May 31, 2017

Conversation

@zieckey
Copy link
Contributor

@zieckey zieckey commented May 28, 2017

This adds support for evpp, a modern C++ network library based on libevent for developing high performance network services in TCP/UDP/HTTP protocols (https://github.com/Qihoo360/evpp).

@msftclas
Copy link

@msftclas msftclas commented May 28, 2017

@zieckey,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@msftclas msftclas commented May 28, 2017

@zieckey, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@msftclas msftclas added cla-signed and removed cla-required labels May 28, 2017
@ras0219-msft ras0219-msft merged commit b1f3f75 into microsoft:master May 31, 2017
@ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented May 31, 2017

Thanks for the PR!

Some suggested improvements:

  • Using vcpkg_from_github() would enable you to pull from the latest master via install --head evpp, which might be able to replace your EVPP_LOCAL_TEST.
  • Each of the vcpkg helpers prints their own statuses, so the extra messages in the portfile are probably unnecessary.
@zieckey
Copy link
Contributor Author

@zieckey zieckey commented May 31, 2017

Thanks. Got it.
We will improve it for next version.

@zieckey zieckey deleted the zieckey:port-evpp branch May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants