New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gdal] Update port to latest GDAL 2.2.2 #1879

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
6 participants
@mloskot
Contributor

mloskot commented Sep 26, 2017

  • Bump GDAL version wherever necessary
  • Update download package and checksum.
  • Remove 0001-Add-support-for-MSVC1900-backported-from-GDAL2.patch
    no longer necessary.
  • Recalculate 000N prefix in patch filenames after the removal.
  • Update 0002-Ensures-inclusion-of-PDB-in-release-dll-if-so-reques.patch
  • Update 0003-Fix-openjpeg-include.patch

Updated port successfully tested locally:

vcpkg install gdal:x86-windows
vcpkg install gdal:x64-windows
[gdal] Update port to latest GDAL 2.2.2
* Bump GDAL version wherever necessary
* Update download package and checksum.
* Remove 0001-Add-support-for-MSVC1900-backported-from-GDAL2.patch
  no longer necessary.
* Recalculate 000N prefix in patche filenames after the removal.
* Update 0002-Ensures-inclusion-of-PDB-in-release-dll-if-so-reques.patch
  * Patch pushed upstream https://trac.osgeo.org/gdal/ticket/7055
    and should no longer be necessary in GDAL 2.2.3 or later
* Update 0003-Fix-openjpeg-include.patch
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 26, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Sep 26, 2017

CLA assistant check
All CLA requirements met.

mloskot added a commit to mloskot/vcpkg that referenced this pull request Sep 26, 2017

[geos] Update port to latest GEOS 3.6.2
* Bump GEOS version wherever necessary
* Update download package and checksum.
* Replace download from SVN with official release source package.
* Remove generating of geos_svn_revision.h as unnecessary -
  released source package includes the header.
* Explain status of the missing CMake modules.
* Remove CMake option -DBUILD_TESTING as unused.

GEOS is important dependency of GDAL (updated in #1879;
GDAL 2.2.2 can still work with GEOS earlier than 3.6.2).

@alexkaratarakis alexkaratarakis self-assigned this Sep 27, 2017

@alex85k

This comment has been minimized.

Show comment
Hide comment
@alex85k

alex85k Oct 4, 2017

Now freexl and spatialite drivers can also be added.

alex85k commented Oct 4, 2017

Now freexl and spatialite drivers can also be added.

jasjuang added a commit to jasjuang/vcpkg that referenced this pull request Oct 11, 2017

[geos] Update port to latest GEOS 3.6.2
* Bump GEOS version wherever necessary
* Update download package and checksum.
* Replace download from SVN with official release source package.
* Remove generating of geos_svn_revision.h as unnecessary -
  released source package includes the header.
* Explain status of the missing CMake modules.
* Remove CMake option -DBUILD_TESTING as unused.

GEOS is important dependency of GDAL (updated in Microsoft#1879;
GDAL 2.2.2 can still work with GEOS earlier than 3.6.2).
@ShinNoNoir

This comment has been minimized.

Show comment
Hide comment
@ShinNoNoir

ShinNoNoir Oct 11, 2017

Contributor

GDAL 2.x does introduce some breaking changes, if I recall correctly, and thus projects relying on GDAL 1.x would most likely break.

Any idea how we should deal with these changes? Perhaps have two different ports, one for GDAL 1.x and one for GDAL 2.x?

Contributor

ShinNoNoir commented Oct 11, 2017

GDAL 2.x does introduce some breaking changes, if I recall correctly, and thus projects relying on GDAL 1.x would most likely break.

Any idea how we should deal with these changes? Perhaps have two different ports, one for GDAL 1.x and one for GDAL 2.x?

@ShinNoNoir

This comment has been minimized.

Show comment
Hide comment
@ShinNoNoir

ShinNoNoir Oct 11, 2017

Contributor

In my search to find some details on the differences between 1.x and 2.x, I stumbled upon this website:

Binary compatibility report for the libgdal.so object between 1.11.5 and 2.0.0 versions on x86_64

Apparently 206 symbols have been removed in the transition from 1.x to 2.x.

Contributor

ShinNoNoir commented Oct 11, 2017

In my search to find some details on the differences between 1.x and 2.x, I stumbled upon this website:

Binary compatibility report for the libgdal.so object between 1.11.5 and 2.0.0 versions on x86_64

Apparently 206 symbols have been removed in the transition from 1.x to 2.x.

@mloskot

This comment has been minimized.

Show comment
Hide comment
@mloskot

mloskot Oct 11, 2017

Contributor

GDAL 1.11.5 is 1.5 years old and I don't think any releases have been planned.
It is highly recommended to switch GDAL 2.x

If vcpkg does maintain single version of a port, then it should be GDAL 2.x

Those who rely on GDAL 1.x should fix their environments at snapshot with the desired version, as per:

Contributor

mloskot commented Oct 11, 2017

GDAL 1.11.5 is 1.5 years old and I don't think any releases have been planned.
It is highly recommended to switch GDAL 2.x

If vcpkg does maintain single version of a port, then it should be GDAL 2.x

Those who rely on GDAL 1.x should fix their environments at snapshot with the desired version, as per:

@ras0219-msft ras0219-msft merged commit 12ac3e9 into Microsoft:master Oct 12, 2017

1 check passed

license/cla All CLA requirements met.
Details
@ras0219-msft

This comment has been minimized.

Show comment
Hide comment
@ras0219-msft

ras0219-msft Oct 12, 2017

Contributor

Thanks for the PR and supplying excellent policy guidance :)!

Contributor

ras0219-msft commented Oct 12, 2017

Thanks for the PR and supplying excellent policy guidance :)!

@mloskot mloskot deleted the mloskot:ml/gdal-2.2.2 branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment