F# RFC FS-1020 - byref returns #1367

Merged
merged 15 commits into from Aug 1, 2016

Conversation

Projects
None yet
3 participants
@dsyme
Contributor

dsyme commented Jul 21, 2016

dsyme added some commits Jul 21, 2016

@dsyme dsyme changed the title from WIP: [RFC FS-1020] byref returns to [WIP] F# RFC FS-1020 - byref returns Jul 21, 2016

dsyme added some commits Jul 22, 2016

@dsyme dsyme changed the title from [WIP] F# RFC FS-1020 - byref returns to F# RFC FS-1020 - byref returns Jul 26, 2016

@dsyme

This comment has been minimized.

Show comment
Hide comment
@dsyme

dsyme Jul 26, 2016

Contributor

This feature is now code-complete and the testing added (subject to getting CI to pass)

Contributor

dsyme commented Jul 26, 2016

This feature is now code-complete and the testing added (subject to getting CI to pass)

- | rest, ClosureFile(filename,m,Some(ParsedInput.ImplFile(ParsedImplFileInput(name,isScript,qualNameOfFile,scopedPragmas,hashDirectives,implFileFlags,_))),errs,warns,nowarns) ->
- rest @ [ClosureFile(filename,m,Some(ParsedInput.ImplFile(ParsedImplFileInput(name,isScript,qualNameOfFile,scopedPragmas,hashDirectives,implFileFlags,(true, tcConfig.target.IsExe)))),errs,warns,nowarns)]
- | _ -> closureFiles
+ if isNil closureFiles then

This comment has been minimized.

@dsyme

dsyme Jul 26, 2016

Contributor

This is a fix unrelated to the feature - I noticed that when calling "fsi foo.fsx" when foo.fsx doesn't exist we hit a crash in List.frontAndBack.

@dsyme

dsyme Jul 26, 2016

Contributor

This is a fix unrelated to the feature - I noticed that when calling "fsi foo.fsx" when foo.fsx doesn't exist we hit a crash in List.frontAndBack.

@KevinRansom

This comment has been minimized.

Show comment
Hide comment
@KevinRansom

KevinRansom Jul 27, 2016

Contributor

@dsyme I see a couple of merge issues can you take care of it pls.

Thanks

Contributor

KevinRansom commented Jul 27, 2016

@dsyme I see a couple of merge issues can you take care of it pls.

Thanks

dsyme added some commits Aug 1, 2016

@KevinRansom

This comment has been minimized.

Show comment
Hide comment
@KevinRansom

KevinRansom Aug 1, 2016

Contributor

@dsyme.Thank you for this contribution

Contributor

KevinRansom commented Aug 1, 2016

@dsyme.Thank you for this contribution

@KevinRansom KevinRansom merged commit c4539e4 into Microsoft:master Aug 1, 2016

4 checks passed

Windows_NT Debug Build Build finished.
Details
Windows_NT Release_ci_part1 Build Build finished.
Details
Windows_NT Release_ci_part2 Build Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment