Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel build inside Visual Studio #487

Conversation

vasily-kirichenko
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Jun 7, 2015

Hi @vasily-kirichenko, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Jun 7, 2015

@vasily-kirichenko, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@forki
Copy link
Contributor

forki commented Jun 7, 2015

Epic! ;-)

@vasily-kirichenko
Copy link
Contributor Author

@forki I think you are right :) Huge thanks @vladima

@enricosada
Copy link
Contributor

awesome @vasily-kirichenko !!

@latkin
Copy link
Contributor

latkin commented Jun 8, 2015

Wow, very cool.

@vladima - any further details that you recall from earlier experiments you mentioned? Were there known issues that resulted in this feature being off by default? I am curious why it is turned off if it is indeed fully baked and tested, or if there are known scenarios that need some attention?

@vladima
Copy link
Contributor

vladima commented Jun 8, 2015

@latkin as I remember Brian has added this key shortly before he left so I think that this feature was never thoughtfully tested.

@vasily-kirichenko
Copy link
Contributor Author

As so, maybe it's better to add a proper setting for this (I mean in the VS UI), at least for first F# 4 release?

@enricosada I know you are the VS settings guru :) Wanna help with the setting?

@dsyme
Copy link
Contributor

dsyme commented Jun 9, 2015

For those wanting to try this out you can enable it by following the instructions here: https://gist.github.com/vasily-kirichenko/84f7ebc284d92742493b

@vasily-kirichenko I'm speaking for @latkin and @KevinRansom, but my understanding is that the feature window has closed for Visual Studio 2015 RTM (they are now in "ask mode", meaning explicit approval is required for bug fixes), but that this would be considered for the first update.

I also found some internal emails about this prototype which @latkin now has, pointing out that there is a minor thread affinity interaction with the VS type provider security warning dialog, but that was the only known issue.

@forki
Copy link
Contributor

forki commented Jun 9, 2015

Another big plus for getting rid of the dialog ;-)
On Jun 9, 2015 11:11, "Don Syme" notifications@github.com wrote:

For those wanting to try this out you can enable it by following the
instructions here:
https://gist.github.com/vasily-kirichenko/84f7ebc284d92742493b

@vasily-kirichenko https://github.com/vasily-kirichenko I'm speaking
for @latkin https://github.com/latkin and @KevinRansom
https://github.com/KevinRansom, but my understanding is that the
feature window has closed for Visual Studio 2015 RTM (they are now in "ask
mode", meaning explicit approval is required for bug fixes), but that this
would be considered for the first update.

I also found some internal emails about this prototype which @latkin
https://github.com/latkin now has, pointing out that there is a minor
thread affinity interaction with the VS type provider security warning
dialog, but that was the only known issue.


Reply to this email directly or view it on GitHub
#487 (comment)
.

@vasily-kirichenko
Copy link
Contributor Author

@dsyme OK, I think we can live with the regex setting for a while (however, VS removes it on regular basis, so it's a bit annoying to constantly check if the flag is still there).

@hmemcpy
Copy link

hmemcpy commented Jun 9, 2015

Just an FYI: modifying anything in the _Config will go away when Visual Studio rebuilds its cache (typically, when running devenv /setup, maybe in other scenarios).
Also, the manual registry tweak only works in the "main" VS hive, not any other custom ones.

A better "workaround" would be to create a enable_fsharp_parallel_builds.pkgdef file, like this:

[$RootKey$\Projects\{f2a71f9b-5d33-465a-a702-920d77279786}]
"IsMultiThreadedBuildEnabled"="1"

and place it under $RootFolder$\Common7\IDE\Extensions

Then, close VS, run devenv /updateconfiguration once from a Developer command prompt, and that's it - VS will add this automatically every time the configuration is updated.

This is a hack, but a more consistent one than manual registry manipulation.

@enricosada
Copy link
Contributor

@hmemcpy an hack worthy of a wiki page, for similar issues

@latkin latkin added this to the vNext milestone Jun 9, 2015
@latkin latkin modified the milestones: F# 4.0 Update 1, vNext Aug 4, 2015
latkin pushed a commit that referenced this pull request Aug 13, 2015
@latkin
Copy link
Contributor

latkin commented Aug 13, 2015

Applied to OOB branch

@latkin latkin closed this Aug 13, 2015
@latkin latkin added the fixed label Aug 13, 2015
@dsyme
Copy link
Contributor

dsyme commented Aug 13, 2015

Great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants