New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC FS-1004] FSharpResult type with a few tests #964
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6e0923a
FsharpResult type with a few tests
wallymathieu af39ca8
Using instance method string.Contains instead of Seq.contains
wallymathieu 1a7f21d
Removed redundant declaration
wallymathieu e862e75
Revert of vs changes to file
wallymathieu 12734f7
Fix for comment about what the file tests
wallymathieu 3d324d1
Added comments and change 'Success' to 'Ok' in Result type
wallymathieu 008465a
Compilation error and surface area tests
wallymathieu 6105902
Merge remote-tracking branch 'Microsoft/master' into fsharp_core_result
wallymathieu 4abfbdb
Compilation error
wallymathieu 7b131d6
Renamed TOk to T
wallymathieu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Core/ResultTests.fs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
||
// Various tests for: | ||
// Microsoft.FSharp.Core.ExtraTopLevelOperators.printf | ||
|
||
namespace FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Core | ||
|
||
open System | ||
open FSharp.Core.Unittests.LibraryTestFx | ||
open NUnit.Framework | ||
|
||
type EmailValidation= | ||
| Empty | ||
| NoAt | ||
|
||
module Results= | ||
let bind f m = match m with Error e -> Error e | Success x -> f x | ||
|
||
open Results | ||
|
||
[<TestFixture>] | ||
type ResultTests() = | ||
|
||
let fail_if_empty email= | ||
if String.IsNullOrEmpty(email) then Error Empty else Success email | ||
|
||
let fail_if_not_at (email:string)= | ||
if (email.Contains("@")) then Success email else Error NoAt | ||
|
||
let validate_email = | ||
fail_if_empty | ||
>> bind fail_if_not_at | ||
|
||
let test_validate_email email (expected:Result<string,EmailValidation>) = | ||
let actual = validate_email email | ||
Assert.AreEqual(expected, actual) | ||
|
||
|
||
[<Test>] | ||
member this.CanChainTogetherSuccessiveValidations() = | ||
test_validate_email "" (Error Empty) | ||
test_validate_email "something_else" (Error NoAt) | ||
test_validate_email "some@email.com" (Success "some@email.com") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust this comment to match the test target.